Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NTO Metrics #158

Merged
merged 1 commit into from Nov 18, 2020
Merged

NTO Metrics #158

merged 1 commit into from Nov 18, 2020

Conversation

jmencak
Copy link
Contributor

@jmencak jmencak commented Oct 1, 2020

Add basic support for Metrics and Alerts.

The following metrics are implemented:

  • nto_pod_labels_used_info
  • nto_profile_set_total
  • nto_build_info
  • nto_degraded_info

Two alerts (NTOPodsNotReady, NTODegraded) are currently being triggered when:

  • Pods are not ready in the Operator namespace for more than 30 minutes.
  • Operator itself is degraded for more than two hours.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 1, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 1, 2020
@jmencak
Copy link
Contributor Author

jmencak commented Oct 1, 2020

While this is marked WiP, this code is tested and I do not expect any major changes. Please review @zvonkok

/cc @courtneypacheco

@jmencak jmencak force-pushed the 4.7-metrics branch 2 times, most recently from c4f087f to d3f769f Compare October 2, 2020 04:31
@jmencak
Copy link
Contributor Author

jmencak commented Oct 2, 2020

/test e2e-aws

2 similar comments
@jmencak
Copy link
Contributor Author

jmencak commented Oct 2, 2020

/test e2e-aws

@jmencak
Copy link
Contributor Author

jmencak commented Oct 2, 2020

/test e2e-aws

@jmencak
Copy link
Contributor Author

jmencak commented Nov 3, 2020

/assign @courtneypacheco

@jmencak jmencak changed the title WiP: NTO Metrics NTO Metrics Nov 5, 2020
@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Nov 5, 2020
@jmencak
Copy link
Contributor Author

jmencak commented Nov 12, 2020

@courtneypacheco PTAL

@jmencak
WiP: NTO Metrics
4250e2b 
Add basic support for Metrics and Alerts.  The following metrics
are implemented:
  - nto_pod_labels_used_info
  - nto_profile_set_total
  - nto_build_info
  - nto_degraded_info

Two alerts (NTOPodsNotReady, NTODegraded) are currently being triggered when:
  - Pods are not ready in the Operator namespace for more than 30 minutes.
  - Operator itself is degraded for more than two hours.
@jmencak
Copy link
Contributor Author

jmencak commented Nov 12, 2020

Had to rebase again due to merged PR177.

@jmencak
Copy link
Contributor Author

jmencak commented Nov 12, 2020

/retest

3 similar comments
@jmencak
Copy link
Contributor Author

jmencak commented Nov 13, 2020

/retest

@jmencak
Copy link
Contributor Author

jmencak commented Nov 13, 2020

/retest

@jmencak
Copy link
Contributor Author

jmencak commented Nov 13, 2020

/retest

courtneypacheco
courtneypacheco approved these changes Nov 13, 2020
View reviewed changes
Copy link

@courtneypacheco courtneypacheco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: courtneypacheco, jmencak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jmencak
Copy link
Contributor Author

jmencak commented Nov 14, 2020

/test e2e-aws

@zvonkok
Copy link

zvonkok commented Nov 15, 2020 via email

@jmencak
Copy link
Contributor Author

jmencak commented Nov 17, 2020

/test all

@jmencak
Copy link
Contributor Author

jmencak commented Nov 18, 2020

/retest

@jmencak
Copy link
Contributor Author

jmencak commented Nov 18, 2020

/joke

@openshift-ci-robot
Copy link
Contributor

@jmencak: I wear a stethoscope so that in a medical emergency I can teach people a valuable lesson about assumptions.

In response to this:

/joke

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 9eb7120 into openshift:master Nov 18, 2020
@jmencak jmencak deleted the 4.7-metrics branch November 18, 2020 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@courtneypacheco courtneypacheco courtneypacheco approved these changes

@Deepthidharwar Deepthidharwar Awaiting requested review from Deepthidharwar

@zvonkok zvonkok Awaiting requested review from zvonkok

Assignees

@courtneypacheco courtneypacheco

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jmencak @openshift-ci-robot @zvonkok @courtneypacheco @openshift-merge-robot