Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1892457: Set scheduling policy to SCHED_FIFO to stalld and lower threshold #169

Merged
merged 1 commit into from Oct 28, 2020

Conversation

jmencak
Copy link
Contributor

@jmencak jmencak commented Oct 27, 2020

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2020
@jmencak
Copy link
Contributor Author

jmencak commented Oct 27, 2020

/retest

1 similar comment
@jmencak
Copy link
Contributor Author

jmencak commented Oct 27, 2020

/retest

Copy link

@kpouget kpouget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found a small nit, see the comment above; the rest of the patch follows the recommendation form https://bugzilla.redhat.com/show_bug.cgi?id=1887568#c26 to launch stalld, so looks good

thanks @jmencak for the PR!

pkg/tuned/host_payload.go Outdated Show resolved Hide resolved
@kpouget
Copy link

kpouget commented Oct 28, 2020

/lgtm

thanks Jiri!

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmencak, kpouget

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit c56a0df into openshift:master Oct 28, 2020
@jmencak jmencak deleted the 4.7-stalld-chrt branch October 28, 2020 15:46
@jmencak
Copy link
Contributor Author

jmencak commented Oct 28, 2020

/cherry-pick release-4.6

@openshift-cherrypick-robot

@jmencak: new pull request created: #170

In response to this:

/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdodson
Copy link
Member

sdodson commented Oct 29, 2020

/retitle Bug 1892459: Set scheduling policy to SCHED_FIFO to stalld and lower threshold

@openshift-ci-robot openshift-ci-robot changed the title Set scheduling policy to SCHED_FIFO to stalld and lower threshold. Bug 1892459: Set scheduling policy to SCHED_FIFO to stalld and lower threshold Oct 29, 2020
@openshift-ci-robot
Copy link
Contributor

@jmencak: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state.

Bugzilla bug 1892459 has not been moved to the MODIFIED state.

In response to this:

Bug 1892459: Set scheduling policy to SCHED_FIFO to stalld and lower threshold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdodson
Copy link
Member

sdodson commented Oct 29, 2020

/retitle Bug 1892457: Set scheduling policy to SCHED_FIFO to stalld and lower threshold

@openshift-ci-robot openshift-ci-robot changed the title Bug 1892459: Set scheduling policy to SCHED_FIFO to stalld and lower threshold Bug 1892457: Set scheduling policy to SCHED_FIFO to stalld and lower threshold Oct 29, 2020
@openshift-ci-robot
Copy link
Contributor

@jmencak: Bugzilla bug 1892457 is in an unrecognized state (VERIFIED) and will not be moved to the MODIFIED state.

In response to this:

Bug 1892457: Set scheduling policy to SCHED_FIFO to stalld and lower threshold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdodson
Copy link
Member

sdodson commented Oct 29, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@sdodson: All pull requests linked via external trackers have merged:

Bugzilla bug 1892457 has been moved to the MODIFIED state.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants