[release-4.6] Bug 1896381: Add a weak dependency on kmod to tuned. #176
Conversation
This fixes an issue in the tuned daemon with a missing
dependency on the kmod package. The [modules] plugin uses
modprobe from the kmod package to load kernel modules.
Other changes:
- Added e2e tests to test this functionality for the loop kernel
module.
- Reused PollExecCmdInPod() for GetFileInPod()
- Removed an unused constant from stalld.go e2e test.
Some exec commands in e2e tests are causing the stdout and stderr to be combined, which causes issues in situations the 'oc' client reports intermittent errors, but the command itself succeeds. Also improved e2e verbosity to find issues with the tests easier.
|
@openshift-cherrypick-robot: Detected clone of Bugzilla bug 1895919 with correct target release. Retitling PR to link to clone: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
changed the title
openshift-ci-robot
added
bugzilla/severity-high
|
@openshift-cherrypick-robot: This pull request references Bugzilla bug 1896381, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/uncc @ArangoGutierrez |
openshift-ci-robot
added
lgtm
|
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
|
@openshift-bot: This pull request references Bugzilla bug 1896381, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
|
@openshift-bot: This pull request references Bugzilla bug 1896381, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@jmencak: This pull request references Bugzilla bug 1896381, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
removed
the
bugzilla/invalid-bug
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jmencak, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jmencak currently 4.6 is only open for stability / upgrade fixes and bugs that are blocking urgent backports. This looks important, but doesn't appear to fall into one of those categories. Is that correct? |
|
@ecordell , this PR fixes two issues. The first one is the inability of operator to load kernel modules. A functionality that is needed by other operators and users that rely on it. Second, it fixes an issue with |
ecordell
added
the
cherry-pick-approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@openshift-cherrypick-robot: All pull requests linked via external trackers have merged: Bugzilla bug 1896381 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #175
/assign jmencak