Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1900196: Automatically restart stalld after exit. #181

Merged
merged 1 commit into from Nov 21, 2020

Conversation

jmencak
Copy link
Contributor

@jmencak jmencak commented Nov 21, 2020

Add "Restart=always" to the stalld unit to restart the stalld service even if
it exits successfully.

Resolves rhbz#1900196.

Add "Restart=always" to the stalld unit to restart the stalld service even if
it exits successfully.

Resolves rhbz#1900196.
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2020
@jmencak jmencak changed the title Automatically restart stalld after exit. Bug 1900196: Automatically restart stalld after exit. Nov 21, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Nov 21, 2020
@openshift-ci-robot
Copy link
Contributor

@jmencak: This pull request references Bugzilla bug 1900196, which is invalid:

  • expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1900196: Automatically restart stalld after exit.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jmencak
Copy link
Contributor Author

jmencak commented Nov 21, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@jmencak: This pull request references Bugzilla bug 1900196, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Nov 21, 2020
@jmencak
Copy link
Contributor Author

jmencak commented Nov 21, 2020

/cc @MarSik
Thank you for the report.

@jmencak
Copy link
Contributor Author

jmencak commented Nov 21, 2020

/uncc @Deepthidharwar

@openshift-ci-robot openshift-ci-robot removed the request for review from Deepthidharwar November 21, 2020 10:38
@MarSik
Copy link
Contributor

MarSik commented Nov 21, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmencak, MarSik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jmencak
Copy link
Contributor Author

jmencak commented Nov 21, 2020

Thanks for the review, Martine.
/retest

@openshift-merge-robot openshift-merge-robot merged commit b7f7ee3 into openshift:master Nov 21, 2020
@openshift-ci-robot
Copy link
Contributor

@jmencak: All pull requests linked via external trackers have merged:

Bugzilla bug 1900196 has been moved to the MODIFIED state.

In response to this:

Bug 1900196: Automatically restart stalld after exit.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jmencak jmencak deleted the 4.7-bz1900196 branch November 21, 2020 19:44
@jmencak
Copy link
Contributor Author

jmencak commented Nov 21, 2020

/cherry-pick release-4.6

@openshift-cherrypick-robot

@jmencak: new pull request created: #182

In response to this:

/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants