Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating cluster-node-tuning-operator builder & base images to be consistent with ART #190

Conversation

openshift-bot
Copy link
Contributor

@openshift-bot openshift-bot commented Jan 12, 2021

Updating cluster-node-tuning-operator builder & base images to be consistent with ART
Reconciling with https://github.com/openshift/ocp-build-data/tree/5bab2562bbfa5695509be4f1de8c6c92d0dd2867/images/cluster-node-tuning-operator.yml

If you have any questions about this pull request, please reach out to @art-team in the #aos-art coreos slack channel.

@openshift-ci-robot
Copy link
Contributor

@openshift-bot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Updating cluster-node-tuning-operator builder & base images to be consistent with ART

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kpouget
Copy link

kpouget commented Jan 13, 2021

seems good to me, all other projects are doing the same.
seems to be related to this comment I received from an OCP mailing list on 2020-12-23:

Test-platform folks have been migrating images from
registry.svc.ci.openshift.org to registry.ci.openshift.org.

but I couldn't find more explanation ...
@jmencak I let you approve the PR, you'll know better than me!

@jmencak
Copy link
Contributor

jmencak commented Jan 13, 2021

Thanks Kevin, there is a thread about these PRs on aos-art. IMO this cannot be merged before we have a 4.6 and 4.7 BZs too. Please stay tuned.

@jmencak
Copy link
Contributor

jmencak commented Jan 13, 2021

Thank you for the PR. Why does it replace only two, out of three FROM registry.svc.ci.openshift.org in the Dockerfile? Thanks!

@openshift-bot openshift-bot force-pushed the art-consistency-openshift-4.6-cluster-node-tuning-operator branch from 72f4ea1 to b3f37aa Compare January 14, 2021 00:34
@openshift-ci-robot
Copy link
Contributor

@openshift-bot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Updating cluster-node-tuning-operator builder & base images to be consistent with ART

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jmencak
Copy link
Contributor

jmencak commented Jan 14, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmencak, openshift-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2021
@openshift-bot
Copy link
Contributor Author

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor Author

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Contributor

@openshift-bot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Updating cluster-node-tuning-operator builder & base images to be consistent with ART

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot openshift-bot added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jan 14, 2021
@openshift-merge-robot openshift-merge-robot merged commit 01d9abf into openshift:release-4.6 Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants