Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating cluster-node-tuning-operator builder & base images to be consistent with ART #191

Merged
merged 1 commit into from Jan 14, 2021
Merged

Updating cluster-node-tuning-operator builder & base images to be consistent with ART #191

merged 1 commit into from Jan 14, 2021

Conversation

openshift-bot
Copy link
Contributor

@openshift-bot openshift-bot commented Jan 13, 2021 •
edited

Updating cluster-node-tuning-operator builder & base images to be consistent with ART
Reconciling with https://github.com/openshift/ocp-build-data/tree/b4edb58f1354f7982e48b868dbffc65e6d597d8f/images/cluster-node-tuning-operator.yml

If you have any questions about this pull request, please reach out to @art-team in the #aos-art coreos slack channel.

@jmencak
Copy link
Contributor

jmencak commented Jan 13, 2021

Thank you for the PR. Why does it replace only two, out of three FROM registry.svc.ci.openshift.org in the Dockerfile? Thanks!

@openshift-bot openshift-bot force-pushed the art-consistency-openshift-4.7-cluster-node-tuning-operator branch from 5e7e6ef to a13d922 Compare January 13, 2021 23:07
jmencak
jmencak approved these changes Jan 14, 2021
View reviewed changes
Copy link
Contributor

@jmencak jmencak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmencak, openshift-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2021
@openshift-bot
Copy link
Contributor Author

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor Author

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor Author

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor Author

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor Author

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor Author

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot openshift-bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 14, 2021
@openshift-merge-robot openshift-merge-robot merged commit 1261fca into openshift:master Jan 14, 2021
@jmencak jmencak mentioned this pull request Dec 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmencak jmencak jmencak approved these changes

@sjug sjug Awaiting requested review from sjug

Assignees

@jmencak jmencak

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@openshift-bot @jmencak @openshift-ci-robot @openshift-merge-robot