Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1920438: Fix openshift-tuned panic on turning debugging on/off. #195

Merged
merged 1 commit into from Jan 26, 2021
Merged

Bug 1920438: Fix openshift-tuned panic on turning debugging on/off. #195

merged 1 commit into from Jan 26, 2021

Conversation

jmencak
Copy link
Contributor

@jmencak jmencak commented Jan 26, 2021

Fixes openshift-tuned panic on turning debugging on/off introduced by:
#192

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2021
@jmencak
Fix openshift-tuned panic on turning debugging on/off.
775755a 
Fixes openshift-tuned panic on turning debugging on/off introduced by:
openshift#192
@jmencak jmencak changed the title Fix openshift-tuned panic on turning debugging on/off. Bug 1920438: Fix openshift-tuned panic on turning debugging on/off. Jan 26, 2021
@openshift-ci-robot
Copy link
Contributor

@jmencak: This pull request references Bugzilla bug 1920438, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1920438: Fix openshift-tuned panic on turning debugging on/off.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jan 26, 2021
@jmencak
Copy link
Contributor Author

jmencak commented Jan 26, 2021

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. and removed bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jan 26, 2021
@openshift-ci-robot
Copy link
Contributor

@jmencak: This pull request references Bugzilla bug 1920438, which is invalid:

  • expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jmencak
Copy link
Contributor Author

jmencak commented Jan 26, 2021

/bugzilla refresh
/joke

@openshift-ci-robot
Copy link
Contributor

@jmencak: I had a rough day, and then somebody went and ripped the front and back pages from my dictionary. It just goes from bad to worse.

In response to this:

/bugzilla refresh
/joke

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@jmencak: This pull request references Bugzilla bug 1920438, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh
/joke

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jan 26, 2021
@jmencak
Copy link
Contributor Author

jmencak commented Jan 26, 2021

/test e2e-aws

ArangoGutierrez
ArangoGutierrez approved these changes Jan 26, 2021
View reviewed changes
Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After reading the logic behind https://github.com/openshift/cluster-node-tuning-operator/blob/master/pkg/tuned/tuned.go#L384 this patch makes sense to me
/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, jmencak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 26, 2021
@jmencak
Copy link
Contributor Author

jmencak commented Jan 26, 2021

/retest

@jmencak jmencak mentioned this pull request Jan 26, 2021
Merged
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit efd902d into openshift:master Jan 26, 2021
@openshift-ci-robot
Copy link
Contributor

@jmencak: All pull requests linked via external trackers have merged:

Bugzilla bug 1920438 has been moved to the MODIFIED state.

In response to this:

Bug 1920438: Fix openshift-tuned panic on turning debugging on/off.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jmencak jmencak deleted the 4.7-channel branch January 27, 2021 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArangoGutierrez ArangoGutierrez ArangoGutierrez approved these changes

@kpouget kpouget Awaiting requested review from kpouget

Assignees

@ArangoGutierrez ArangoGutierrez

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jmencak @openshift-ci-robot @openshift-bot @ArangoGutierrez @openshift-merge-robot