Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1928614: Keep ignition units in sync with [service] plugin. #215

Merged
merged 1 commit into from Mar 23, 2021
Merged

Bug 1928614: Keep ignition units in sync with [service] plugin. #215

merged 1 commit into from Mar 23, 2021

Conversation

jmencak
Copy link
Contributor

@jmencak jmencak commented Mar 4, 2021

Changes:

  • new vendor dependency 'gopkg.in/ini.v1' to parse INI files
  • openshift-tuned now parses Tuned profiles and searches for
    'stalld' enabled/disabled by [service] plugin; systemd
    ignition file units are now created with this enablement
    information
  • improving e2e tests for the stalld functionality
  • better logging for e2e tests failures
  • fix e2e tests for default_irq_smp_affinity on platforms
    with wider affinity masks than usual (e.g. Xen)

Resolves rhbz#1928614.

@jmencak
Keep ignition units in sync with [service] plugin.
50321f8 
Changes:
  - new vendor dependency 'gopkg.in/ini.v1' to parse INI files
  - openshift-tuned now parses Tuned profiles and searches for
    'stalld' enabled/disabled by [service] plugin; systemd
    ignition file units are now created with this enablement
     information
  - improving e2e tests for the stalld functionality
  - better logging for e2e tests failures
  - fix e2e tests for default_irq_smp_affinity on platforms
    with wider affinity masks than usual (e.g. Xen)

Resolves rhbz#1928614.
@openshift-ci-robot
Copy link
Contributor

@jmencak: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Keep ignition units in sync with [service] plugin.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2021
@jmencak
Copy link
Contributor Author

jmencak commented Mar 4, 2021

This PR combined two PRs already merged in the master/4.8 branch:

@jmencak jmencak changed the title Keep ignition units in sync with [service] plugin. Bug 1928614: Keep ignition units in sync with [service] plugin. Mar 4, 2021
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Mar 4, 2021
@openshift-ci-robot
Copy link
Contributor

@jmencak: This pull request references Bugzilla bug 1928614, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.z) matches configured target release for branch (4.7.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1926903 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1926903 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0
  • bug has dependents

In response to this:

Bug 1928614: Keep ignition units in sync with [service] plugin.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Mar 4, 2021
@kpouget
Copy link

kpouget commented Mar 4, 2021 •
edited

thanks for the PR Jiri ;-)

tests are passing and #207 #211 were already reviewed, so:

/gtm

@kpouget
Copy link

kpouget commented Mar 4, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmencak, kpouget

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jmencak
Copy link
Contributor Author

jmencak commented Mar 4, 2021

/test e2e-upgrade

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@jmencak jmencak mentioned this pull request Mar 22, 2021
Merged
@ecordell ecordell added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 22, 2021
@jmencak
Copy link
Contributor Author

jmencak commented Mar 22, 2021

/retest

1 similar comment
@jmencak
Copy link
Contributor Author

jmencak commented Mar 23, 2021

/retest

@jmencak
Copy link
Contributor Author

jmencak commented Mar 23, 2021

/test all

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@jmencak
Copy link
Contributor Author

jmencak commented Mar 23, 2021

/hold
until the CI is fixed

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 23, 2021
@jmencak
Copy link
Contributor Author

jmencak commented Mar 23, 2021

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 23, 2021
@jmencak
Copy link
Contributor Author

jmencak commented Mar 23, 2021

/test all

@openshift-merge-robot openshift-merge-robot merged commit 78e1417 into openshift:release-4.7 Mar 23, 2021
@openshift-ci-robot
Copy link
Contributor

@jmencak: All pull requests linked via external trackers have merged:

Bugzilla bug 1928614 has been moved to the MODIFIED state.

In response to this:

Bug 1928614: Keep ignition units in sync with [service] plugin.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jmencak jmencak deleted the 4.7-bz1928614 branch March 23, 2021 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dagrayvid dagrayvid Awaiting requested review from dagrayvid

@kpouget kpouget Awaiting requested review from kpouget

Assignees

@kpouget kpouget

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jmencak @openshift-ci-robot @kpouget @openshift-bot @ecordell @openshift-merge-robot