Bug 1974277: Fix conditional order for setting net device param.

[jmencak]

The conditional for setting a net device parameter in TuneD has a wrong order where it can potentially try to first cast a string to int in a wrong manner and only then check if the value is a specific integer value.

Upstream TuneD fix: redhat-performance/tuned#360

Resolves rhbz#1974277.

[jmencak]

Subject to upstream patch merging:
redhat-performance/tuned#360
/hold

[openshift-ci]

@jmencak: This pull request references Bugzilla bug 1974277, which is invalid:

• expected the bug to target the "4.9.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1974277: Fix conditional order for setting net device param.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jmencak]

/bugzilla refresh

[openshift-ci]

@jmencak: This pull request references Bugzilla bug 1974277, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.9.0) matches configured target release for branch (4.9.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (skordas@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jmencak]

/cc @yanirq

[kpouget]

makes sense to me,

(int(dev_params[next(iter(d))]) == 0 or str(dev_params[next(iter(d))]) == 'n/a')

the 2nd hand of the or can never be true, as int(...) will raise an exception if dev_params[next(iter(d))] isn't a sequence of digits, eg n/a

[yanirq]

makes sense to me,

(int(dev_params[next(iter(d))]) == 0 or str(dev_params[next(iter(d))]) == 'n/a')

the 2nd hand of the or can never be true, as int(...) will raise an exception if dev_params[next(iter(d))] isn't a sequence of digits, eg n/a

yes. this is the reason for the fix. tuned throws an unhandled exception in that case.
/lgtm

[yanirq]

/hold - for NTO reviewers

[jmencak]

No need for the torture, this patch cannot possibly cause an upgrade failure
/override ci/prow/e2e-upgrade

[openshift-ci]

@jmencak: Overrode contexts on behalf of jmencak: ci/prow/e2e-upgrade

In response to this:

No need for the torture, this patch cannot possibly cause an upgrade failure
/override ci/prow/e2e-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kpouget]

indeed, makes more sense written like that!

[jmencak]

redhat-performance/tuned#360 merged
Squashed commits.
/hold cancel
@yanirq , feel free to add /lgtm if this looks good.

[yanirq]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmencak, yanirq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jmencak]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci]

@jmencak: All pull requests linked via external trackers have merged:

• openshift/cluster-node-tuning-operator#239

Bugzilla bug 1974277 has been moved to the MODIFIED state.

In response to this:

Bug 1974277: Fix conditional order for setting net device param.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jmencak]

/cherry-pick release-4.8

[openshift-cherrypick-robot]

@jmencak: new pull request created: #240

In response to this:

/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.