Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusting the OWNERS file due to team changes. #244

Merged
merged 1 commit into from Jun 30, 2021

Conversation

jmencak
Copy link
Contributor

@jmencak jmencak commented Jun 30, 2021

No description provided.

@jmencak
Copy link
Contributor Author

jmencak commented Jun 30, 2021

/override ci/prow/e2e-aws
/override ci/prow/e2e-aws-operator
/override ci/prow/e2e-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 30, 2021

@jmencak: /override requires a failed status context to operate on.
The following unknown contexts were given:

  • ci/prow/e2e-aws
  • ci/prow/e2e-aws-operator
  • ci/prow/e2e-upgrade

Only the following contexts were expected:

  • tide

In response to this:

/override ci/prow/e2e-aws
/override ci/prow/e2e-aws-operator
/override ci/prow/e2e-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2021
Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 30, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, jmencak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2021
@ArangoGutierrez
Copy link
Contributor

/override ci/prow/images

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 30, 2021

@ArangoGutierrez: ArangoGutierrez unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file.

In response to this:

/override ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jmencak
Copy link
Contributor Author

jmencak commented Jun 30, 2021

/override ci/prow/images

Turns out one can only override stuff that failed. It would be good to skip the tests completely (not even start them). Let's try again though and see what the bot thinks:
/override ci/prow/e2e-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 30, 2021

@jmencak: Overrode contexts on behalf of jmencak: ci/prow/e2e-upgrade

In response to this:

/override ci/prow/images

Turns out one can only override stuff that failed. It would be good to skip the tests completely (not even start them). Let's try again though and see what the bot thinks:
/override ci/prow/e2e-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jmencak
Copy link
Contributor Author

jmencak commented Jun 30, 2021

Aaah, ok, so it looks the job has to start:
/override ci/prow/e2e-aws-operator
/override ci/prow/e2e-aws

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 30, 2021

@jmencak: Overrode contexts on behalf of jmencak: ci/prow/e2e-aws, ci/prow/e2e-aws-operator

In response to this:

Aaah, ok, so it looks the job has to start:
/override ci/prow/e2e-aws-operator
/override ci/prow/e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit cabe142 into openshift:master Jun 30, 2021
@jmencak jmencak deleted the approvers branch June 30, 2021 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants