Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship the latest TuneD, adjust default Tuned CR. #245

Merged
merged 1 commit into from Jul 15, 2021

Conversation

jmencak
Copy link
Contributor

@jmencak jmencak commented Jul 5, 2021

This PR ships the latest TuneD daemon 2.16.0-0.1.rc1.

Other changes:

  • adjust the openshift-tuned code to reflect the upstream project renaming
  • adjust the default Tuned CR to work with kernels 5.13+ (see rhbz#1952687)

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 5, 2021
@jmencak
Copy link
Contributor Author

jmencak commented Jul 5, 2021

Do not merge, yet. Wait for the official v2.16.0 upstream tag and rebase. Other thant that, it should be good to go.
/retitle WiP: Ship the latest TuneD, adjust default Tuned CR.

@openshift-ci openshift-ci bot changed the title Ship the latest TuneD, adjust default Tuned CR. WiP: Ship the latest TuneD, adjust default Tuned CR. Jul 5, 2021
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 5, 2021
This PR ships the latest TuneD daemon 2.16.0-0.1.rc1.

Other changes:
  - adjust the openshift-tuned code to reflect the upstream project
    renaming
  - adjust the default Tuned CR to work with kernels 5.13+ (see
    rhbz#1952687)
@kpouget
Copy link

kpouget commented Jul 8, 2021

Hey @jmencak, thanks for the PR!

adjust the default Tuned CR to work with kernels 5.13+ (see rhbz#1952687)

I don't understand what hunk is doing this, could you give a link to this is change?

@jmencak
Copy link
Contributor Author

jmencak commented Jul 8, 2021

Flake.
/retest

@jmencak
Copy link
Contributor Author

jmencak commented Jul 8, 2021

Hey @jmencak, thanks for the PR!

adjust the default Tuned CR to work with kernels 5.13+ (see rhbz#1952687)

I don't understand what hunk is doing this, could you give a link to this is change?

It is the changes in the default-cr-tuned.yaml file.

@jmencak
Copy link
Contributor Author

jmencak commented Jul 8, 2021

/retest
/joke

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 8, 2021

@jmencak: Hear about the new restaurant called Karma? There’s no menu: You get what you deserve.

In response to this:

/retest
/joke

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jmencak
Copy link
Contributor Author

jmencak commented Jul 8, 2021

Let's get this tested in 4.9 as soon as we can to discover real issues.

/override ci/prow/e2e-upgrade
/retitle Ship the latest TuneD, adjust default Tuned CR.

@openshift-ci openshift-ci bot changed the title WiP: Ship the latest TuneD, adjust default Tuned CR. Ship the latest TuneD, adjust default Tuned CR. Jul 8, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 8, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 8, 2021

@jmencak: Overrode contexts on behalf of jmencak: ci/prow/e2e-upgrade

In response to this:

Let's get this tested in 4.9 as soon as we can to discover real issues.

/override ci/prow/e2e-upgrade
/retitle Ship the latest TuneD, adjust default Tuned CR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jmencak
Copy link
Contributor Author

jmencak commented Jul 12, 2021

@ArangoGutierrez , any chance of a quick review in Kevin's absence? Thanks!

@ArangoGutierrez
Copy link
Contributor

Tried and tested
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 15, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, jmencak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ArangoGutierrez
Copy link
Contributor

Ran 3 of 3 Specs in 1340.902 seconds
SUCCESS! -- 3 Passed | 0 Failed | 0 Pending | 0 Skipped
--- PASS: TestNodeTuningOperator (1340.90s)
PASS
ok      github.com/openshift/cluster-node-tuning-operator/test/e2e/reboots      1340.915s

@jmencak
Copy link
Contributor Author

jmencak commented Jul 15, 2021

/test e2e-aws

@jmencak
Copy link
Contributor Author

jmencak commented Jul 15, 2021

e2e-upgrade (s) are failing at the moment, that's a known issue, but try too
/test e2e-upgrade

@jmencak
Copy link
Contributor Author

jmencak commented Jul 15, 2021

e2e-upgrade (s) are failing at the moment, that's a known issue, but try too
/test e2e-upgrade

/override e2e-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 15, 2021

@jmencak: /override requires a failed status context or a job name to operate on.
The following unknown contexts were given:

  • e2e-upgrade

Only the following contexts were expected:

  • ci/prow/e2e-aws
  • ci/prow/e2e-aws-operator
  • ci/prow/e2e-upgrade
  • ci/prow/images
  • ci/prow/unit
  • ci/prow/verify
  • pull-ci-openshift-cluster-node-tuning-operator-release-4.1-e2e-aws
  • pull-ci-openshift-cluster-node-tuning-operator-release-4.1-images
  • pull-ci-openshift-cluster-node-tuning-operator-release-4.1-unit
  • pull-ci-openshift-cluster-node-tuning-operator-release-4.1-verify
  • pull-ci-openshift-cluster-node-tuning-operator-release-4.4-e2e-upgrade
  • pull-ci-openshift-cluster-node-tuning-operator-release-4.6-e2e-aws-operator
  • tide

In response to this:

e2e-upgrade (s) are failing at the moment, that's a known issue, but try too
/test e2e-upgrade

/override e2e-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jmencak
Copy link
Contributor Author

jmencak commented Jul 15, 2021

/override ci/prow/e2e-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 15, 2021

@jmencak: Overrode contexts on behalf of jmencak: ci/prow/e2e-upgrade

In response to this:

/override ci/prow/e2e-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 45469e9 into openshift:master Jul 15, 2021
@jmencak jmencak deleted the 4.9-tuned-v2.16.0 branch July 15, 2021 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants