Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address a race in the stalld e2e test. #249

Merged
merged 1 commit into from Jul 21, 2021
Merged

Address a race in the stalld e2e test. #249

merged 1 commit into from Jul 21, 2021

Conversation

jmencak
Copy link
Contributor

@jmencak jmencak commented Jul 15, 2021

The race was sometimes causing the TuneD daemon re-enable and start stalld service after it was intentionally stopped by the test itself using systemctl.

@openshift-ci openshift-ci bot requested review from kpouget and zvonkok July 15, 2021 12:10
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2021
@jmencak
Copy link
Contributor Author

jmencak commented Jul 15, 2021

@omertuc , thank you for bringing my attention to this issue. Hopefully this PR fixes it.

@jmencak
Address a race in the stalld e2e test.
d7bcbd6 
The race was sometimes causing the TuneD daemon re-enable and start
`stalld` service after it was intentionally stopped by the test itself
using systemctl.
@jmencak
Copy link
Contributor Author

jmencak commented Jul 15, 2021

Great, pass on the ci/prow/e2e-aws-operator upgrade tests are known to fail right now.

@jmencak
Copy link
Contributor Author

jmencak commented Jul 21, 2021

/test e2e-upgrade

@jmencak
Copy link
Contributor Author

jmencak commented Jul 21, 2021

All tests pass now, @zvonkok , could I please have a review? Thank you!

@zvonkok
Copy link

zvonkok commented Jul 21, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 21, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmencak, zvonkok

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit f76c667 into openshift:master Jul 21, 2021
@jmencak jmencak deleted the 4.9-stalld-e2e branch July 21, 2021 11:17
@jmencak
Copy link
Contributor Author

jmencak commented Oct 10, 2021

/cherry-pick release-4.8

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 10, 2021
Closed
@openshift-cherrypick-robot
Copy link

@jmencak: new pull request created: #277

In response to this:

/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpouget kpouget Awaiting requested review from kpouget

@zvonkok zvonkok Awaiting requested review from zvonkok

Assignees

@zvonkok zvonkok

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jmencak @zvonkok @openshift-cherrypick-robot @openshift-merge-robot