New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBM Cloud manifest profile patch for operator deployment #252
IBM Cloud manifest profile patch for operator deployment #252
Conversation
9a8bbc5
to
b1c8328
Compare
Thank you for the PR, @ csrwng . Could you please explain why we need a separate |
@csrwng , I think I see the point now, so you cannot use
on IBM Cloud for some reason. How do we make sure |
Hi @jmencak this is part of the cluster profiles support in the CVO (openshift/cluster-version-operator#404). At any one time, there is only one cluster profile in effect when the CVO applies manifests to the cluster. The default profile is the |
Thank you for the explanation, Cesar. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csrwng, jmencak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
Bumps build-machinery-go to latest
Adds patch specific to ibm-cloud-managed profile that generates a manifest that removes node selector for operator deployment
make verify
verifies that the generated manifest is up to datemake update
updates the manifest by applying the ibm-cloud-managed patch to the original deployment manifest