Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1997486: Ship the latest TuneD and stalld. #265

Merged
merged 1 commit into from Aug 26, 2021
Merged

Bug 1997486: Ship the latest TuneD and stalld. #265

merged 1 commit into from Aug 26, 2021

Conversation

jmencak
Copy link
Contributor

@jmencak jmencak commented Aug 25, 2021

Changes:

  • updated to the latest TuneD.
  • dropped several TuneD patches already included in the latest TuneD.
  • added a temporary fix to address AWS-specific tuning for NVMe
    devices until we have a proper way to deliver cloud-provider
    specific tuning (resolves rhbz#1997486).
  • updated https://gitlab.com/rt-linux-tools/stalld.git to v1.14.2
  • better debugging for e2e tests when retrying commands in pods:
    show how long we waited for completion.

@jmencak
Ship the latest TuneD and stalld.
b003fc9 
Changes:
   - updated to the latest TuneD.
   - dropped several TuneD patches already included in the latest TuneD.
   - added a temporary fix to address AWS-specific tuning for NVMe
     devices until we have a proper way to deliver cloud-provider
     specific tuning.
   - updated https://gitlab.com/rt-linux-tools/stalld.git to v1.14.2
   - better debugging for e2e tests when retrying commands in pods:
     show how long we waited for completion.
@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Aug 25, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 25, 2021

@jmencak: This pull request references Bugzilla bug 1997486, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (skordas@redhat.com), skipping review request.

In response to this:

Bug 1997486: Ship the latest TuneD and stalld.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from kpouget and zvonkok August 25, 2021 18:53
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2021
@jmencak
Copy link
Contributor Author

jmencak commented Aug 25, 2021

Tested 4 times out of CI. e2e-aws-operator tests were passing without issues.

@jmencak
Copy link
Contributor Author

jmencak commented Aug 26, 2021

/test e2e-upgrade

@kpouget
Copy link

kpouget commented Aug 26, 2021

Hello @jmencak , thanks for the PR :)

the changes look fine, but I had a bit of trouble matching them with the PR description:

  • updated to the latest TuneD.

this is the change in the Makefile ✅

+ TUNED_COMMIT:=bcbf2a54899d73605aaa7318b6578066de2155f2
  • better debugging for e2e tests when retrying commands in pods:
    show how long we waited for completion.

this is the change in test/e2e/util/util.go ✅

was assets/tuned/stalld/ automatically updated by changing TUNED_COMMIT? or manually updated to v1.14.2?

  • dropped several TuneD patches already included in the latest TuneD.

not sure how this is visible in the commit, part of changing TUNED_COMMIT?

  • added a temporary fix to address AWS-specific tuning for NVMe
    devices until we have a proper way to deliver cloud-provider
    specific tuning (resolves rhbz#1997486).

not sure how this is visible in the commit, part of changing TUNED_COMMIT?

@jmencak
Copy link
Contributor Author

jmencak commented Aug 26, 2021

/cc @liqcui

@openshift-ci openshift-ci bot requested a review from liqcui August 26, 2021 07:55
@jmencak
Copy link
Contributor Author

jmencak commented Aug 26, 2021 •
edited

Hello @jmencak , thanks for the PR :)

Thank you for the review, @kpouget ! :)

was assets/tuned/stalld/ automatically updated by changing TUNED_COMMIT? or manually updated to v1.14.2?

No, only TuneD was automatically updated by changing TUNED_COMMIT and make clone-tuned. Stalld, however, was updated manually. Stalld is on the way out of NTO. It is already being shipped by CoreOS and once we're at least at version 1.14.1 in CoreOS, I'm planning to switch to it completely, so it probably makes little sense to create an automation for that at this point.

* dropped several TuneD patches already included in the latest TuneD.

not sure how this is visible in the commit, part of changing TUNED_COMMIT?

No, please see the manually deleted patches in assets/tuned/patches.

* added a temporary fix to address AWS-specific tuning for NVMe
  devices until we have a proper way to deliver cloud-provider
  specific tuning (resolves rhbz#1997486).

not sure how this is visible in the commit, part of changing TUNED_COMMIT?

No, manually added assets/tuned/patches/040-openshift-profiles-aws.diff.

@kpouget
Copy link

kpouget commented Aug 26, 2021

thanks for the explanations @jmencak, LGTM, but I'll let @liqcui have a look and confirm he's happy with the PR!

@jmencak
Copy link
Contributor Author

jmencak commented Aug 26, 2021

Bot, tell us some
/joke
please.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 26, 2021

@jmencak: What do you call a sheep with no legs? A cloud.

In response to this:

Bot, tell us some
/joke
please.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

liqcui
liqcui approved these changes Aug 26, 2021
View reviewed changes
Copy link

@liqcui liqcui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 26, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmencak, liqcui

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit e5c8e15 into openshift:master Aug 26, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 26, 2021

@jmencak: All pull requests linked via external trackers have merged:

Bugzilla bug 1997486 has been moved to the MODIFIED state.

In response to this:

Bug 1997486: Ship the latest TuneD and stalld.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jmencak jmencak deleted the 4.9-bz1997486-openshift-profile-aws branch August 26, 2021 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liqcui liqcui liqcui approved these changes

@kpouget kpouget Awaiting requested review from kpouget

@zvonkok zvonkok Awaiting requested review from zvonkok

Assignees

@liqcui liqcui

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jmencak @kpouget @liqcui @openshift-merge-robot