Bug 1998247: Reload when deps of recommended profile change. #267
Conversation
openshift-ci
bot
added
the
bugzilla/severity-high
|
@jmencak: This pull request references Bugzilla bug 1998247, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (skordas@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
bugzilla/valid-bug
openshift-ci
bot
added
the
approved
|
/uncc @zvonkok |
openshift-ci
bot
requested review from
dagrayvid
and removed request for
zvonkok
|
/test e2e-upgrade |
|
/retest |
|
/joke |
|
@jmencak: I asked the surgeon if I could administer my own anesthetic, they said: go ahead, knock yourself out. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
thanks for the PR @jmencak, I went through the code and I think it all makes sense! the logic was complex to follow (by nature), but I think I managed to follow the thread :) /lgtm |
openshift-ci
bot
added
the
do-not-merge/hold
This change fixes operand's behavior during administrator-initiated changes of TuneD profiles that the currently recommended TuneD profile depends on. Now, changes to any such dependent profile and changes to the recommended TuneD profile will cause TuneD daemon reload. Resolves rhbz#1998247.
jmencak
force-pushed
the
4.9-bz1998247-deps_of_recommended
branch
from
3b5322c
to
6c7f05e
Compare
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
thanks @jmencak |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jmencak, kpouget The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@jmencak: All pull requests linked via external trackers have merged: Bugzilla bug 1998247 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cc @skordas |
This change fixes operand's behavior during administrator-initiated changes of TuneD profiles that the currently recommended TuneD profile depends on. Now, changes to any such dependent profile and changes to the recommended TuneD profile will cause TuneD daemon reload.
Resolves rhbz#1998247.