[release-4.9] Bug 2033652: Handle certificate rotation in pkg/metrics/server.go

[openshift-cherrypick-robot]

This is an automated cherry-pick of #297

/assign dagrayvid

[openshift-ci]

@openshift-cherrypick-robot: Bugzilla bug 2026387 has been cloned as Bugzilla bug 2033652. Retitling PR to link against new bug.
/retitle [release-4.9] Bug 2033652: Handle certificate rotation in pkg/metrics/server.go

In response to this:

[release-4.9] Bug 2026387: Handle certificate rotation in pkg/metrics/server.go

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2033652, which is invalid:

• expected dependent Bugzilla bug 2026387 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.9] Bug 2033652: Handle certificate rotation in pkg/metrics/server.go

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dagrayvid]

@jmencak this make verify failure seems to be the same issue with yaml-patch that you solved with #299. Should #299 be backported?

[jmencak]

@jmencak this make verify failure seems to be the same issue with yaml-patch that you solved with #299. Should #299 be backported?

Yes. I believe you'll need a 4.10 BZ in at least ON_QE. Can you do that? Thanks!

[jmencak]

/retest
/bugzilla refresh

[openshift-ci]

@jmencak: This pull request references Bugzilla bug 2033652, which is invalid:

• expected dependent Bugzilla bug 2026387 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/retest
/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-bot]

/bugzilla refresh

The requirements for Bugzilla bugs have changed, recalculating validity.

[openshift-ci]

@openshift-bot: This pull request references Bugzilla bug 2033652, which is invalid:

• expected dependent Bugzilla bug 2026387 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

The requirements for Bugzilla bugs have changed, recalculating validity.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dagrayvid]

/bugzilla refresh

[openshift-ci]

@dagrayvid: This pull request references Bugzilla bug 2033652, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.9.z) matches configured target release for branch (4.9.z)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 2026387 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
• dependent Bugzilla bug 2026387 targets the "4.10.0" release, which is one of the valid target releases: 4.10.0
• bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (liqcui@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dagrayvid]

@jmencak @wabouhamad, please add the necessary backport labels if this PR looks good to you.

[jmencak]

Backport risk assessment

• If the Bugzilla associated with the PR has the "FastFix" keyword, the subjective assessment on the issue has already been done and a customer is impacted. These PRs should be prioritized for merge.
  • not applicable
• For branches that are in the Maintenance lifecycle phase:
  • not applicable
• The bug has significant impact either through severity, reduction in supportability, or number of users affected.
  • yes
• The severity field of the bug must be set to accurately reflect criticality.
  • bugzilla/severity-high
• The PR is merged in the next newer release branch and the bug for that newer release is VERIFIED by QE.
  • yes
• The PR’s description is well formed with user-focused release notes that state the bug number, impact, cause, and resolution. Where appropriate, it should also contain information about how a user can identify whether a particular cluster is affected.
  • yes

/label backport-risk-assessed
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmencak, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jmencak]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[wabouhamad]

/label cherry-pick-approved

[dagrayvid]

/lgtm

[openshift-ci]

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci]

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

• openshift/cluster-node-tuning-operator#305

Bugzilla bug 2033652 has been moved to the MODIFIED state.

In response to this:

[release-4.9] Bug 2033652: Handle certificate rotation in pkg/metrics/server.go

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dagrayvid]

/cherry-pick release-4.8

[openshift-cherrypick-robot]

@dagrayvid: new pull request created: #310

In response to this:

/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.