Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish ClusterOperator status. #35

Merged
merged 1 commit into from
Jan 28, 2019
Merged

Publish ClusterOperator status. #35

merged 1 commit into from
Jan 28, 2019

Conversation

jmencak
Copy link
Contributor

@jmencak jmencak commented Jan 23, 2019

This PR adds support for publishing ClusterOperator status
https://github.com/openshift/api/blob/master/config/v1/types_cluster_operator.go#L33

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 23, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 23, 2019
sjug
sjug reviewed Jan 24, 2019
View reviewed changes
Copy link
Contributor

@sjug sjug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the most part. Have not run the e2e tests yet as I've not been able to get a good cluster from master today.

pkg/config/config.go Outdated Show resolved Hide resolved
pkg/controller/tuned/status.go Outdated Show resolved Hide resolved
pkg/controller/tuned/status.go Show resolved Hide resolved
pkg/controller/tuned/tuned_controller.go Show resolved Hide resolved
pkg/util/clusteroperator/status.go Show resolved Hide resolved
@jmencak
Copy link
Contributor Author

jmencak commented Jan 24, 2019

Hold the merge until the commits are squashed.
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 24, 2019
@sjug
Copy link
Contributor

sjug commented Jan 28, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmencak, sjug

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jmencak
Copy link
Contributor Author

jmencak commented Jan 28, 2019

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 28, 2019
@openshift-merge-robot openshift-merge-robot merged commit 665d951 into openshift:master Jan 28, 2019
@jmencak jmencak deleted the cluster-operator-status branch January 30, 2019 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjug sjug sjug left review comments

Assignees

@sjug sjug

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jmencak @sjug @openshift-ci-robot @openshift-merge-robot