Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrading to operator-sdk 0.4.0 #38

Merged
merged 1 commit into from
Feb 6, 2019
Merged

Upgrading to operator-sdk 0.4.0 #38

merged 1 commit into from
Feb 6, 2019

Conversation

jmencak
Copy link
Contributor

@jmencak jmencak commented Feb 5, 2019

@sjug PTAL

@jmencak
Copy link
Contributor Author

jmencak commented Feb 5, 2019

/hold

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 5, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2019
@sjug
Copy link
Contributor

sjug commented Feb 6, 2019

Tested and working. Didn't seem to need that many changes to the actual operator pkg/?

@jmencak
Copy link
Contributor Author

jmencak commented Feb 6, 2019

@sjug, not sure which changes you're talking about, but the e2e tests were not working without a few more changes. If you're talking about the extra cleanup, then yes, this PR is not about just the upgrade, but cleanup too.

@jmencak
Copy link
Contributor Author

jmencak commented Feb 6, 2019

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 6, 2019
@openshift-merge-robot
Copy link
Contributor

/retest

1 similar comment
@openshift-merge-robot
Copy link
Contributor

/retest

@sjug
Copy link
Contributor

sjug commented Feb 6, 2019 •
edited

@jmencak I'm talking about the changes to the operator code which were needed in order to update to the operator-sdk v0.4.0. As far as I can tell from the title of the PR and the commit name, that's what's contained in this PR.

@sjug
Copy link
Contributor

sjug commented Feb 6, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmencak, sjug

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 4f7f32e into openshift:master Feb 6, 2019
@jmencak jmencak deleted the sdk-0.4.x branch February 7, 2019 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjug sjug Awaiting requested review from sjug

Assignees

@sjug sjug

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jmencak @sjug @openshift-merge-robot @openshift-ci-robot