Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"OCPBUGS-63: e2e: performance: configure isolated cpus in the profile" #446

Closed
wants to merge 1 commit into from
Closed

"OCPBUGS-63: e2e: performance: configure isolated cpus in the profile" #446

wants to merge 1 commit into from

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #429

/assign shajmakh

@shajmakh
e2e: performance: Update PP isolated cpus
bc69989 
Some tests in the suites require setting the number of CPUs to be used by the latency pod. If the available cpus is not sufficient, the tests will be skipped.
The goal of the suite is to verify that the main tests of the latency tools are executed as expected.
So to overcome this, update the isolated CPUs for this suite to CPU set that guarantees to execute the tests properly, and restore the initial set when finished.

Signed-off-by: shereenH <shajmakh@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 25, 2022
Merged
@shajmakh
Copy link
Contributor

shajmakh commented Aug 25, 2022 •
edited by openshift-ci bot

/retitle "OCPBUGS-63: e2e: performance: configure isolated cpus in the profile"

@openshift-ci openshift-ci bot changed the title [release-4.11] e2e: performance: configure isolated cpus in the profile "OCPBUGS-63: e2e: performance: configure isolated cpus in the profile" Aug 25, 2022
@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Aug 25, 2022
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 25, 2022 •
edited by openshift-ci bot

@openshift-cherrypick-robot: This pull request references [Jira Issue OCPBUGS-63](https://issues.redhat.com//browse/OCPBUGS-63), which is invalid:

  • expected the bug to target the "4.11.z" version, but it targets "4.11.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

This is an automated cherry-pick of #429

/assign shajmakh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 25, 2022 •
edited

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

"OCPBUGS-63: e2e: performance: configure isolated cpus in the profile"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@shajmakh
Copy link
Contributor

/jira refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 25, 2022 •
edited by openshift-ci bot

@shajmakh: This pull request references [Jira Issue OCPBUGS-63](https://issues.redhat.com//browse/OCPBUGS-63), which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, but it is In Progress instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@shajmakh
Copy link
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 25, 2022
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 25, 2022 •
edited by openshift-ci bot

@shajmakh: This pull request references [Jira Issue OCPBUGS-63](https://issues.redhat.com//browse/OCPBUGS-63), which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.11.z) matches configured target version for branch (4.11.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST)
  • dependent bug [Jira Issue OCPBUGS-65](https://issues.redhat.com//browse/OCPBUGS-65) is in the state Verified (Done), which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent [Jira Issue OCPBUGS-65](https://issues.redhat.com//browse/OCPBUGS-65) targets the "4.12.0" version, which is one of the valid target versions: 4.12.0
  • bug has dependents

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@shajmakh
Copy link
Contributor

@MarSik / @yanirq can you provide approved and backport-risk-assessed please?

@yanirq
Copy link
Contributor

yanirq commented Aug 29, 2022

/approve
/backport-risk-assessed

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2022
@yanirq
Copy link
Contributor

yanirq commented Aug 29, 2022

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Aug 29, 2022
@shajmakh
Copy link
Contributor

/label cherry-pick-approved
/lgtm

@openshift-ci openshift-ci bot added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. labels Aug 29, 2022
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD 112225c and 8 for PR HEAD bc69989 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 1 against base HEAD 112225c and 7 for PR HEAD bc69989 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 112225c and 6 for PR HEAD bc69989 in total

@shajmakh
Copy link
Contributor

/test e2e-gcp-pao

@marioferh
Copy link
Contributor

this test is failing:

[test_id:36150] Verify that IRQ load balancing is enabled/disabled correctly [It]

Maybe last irqbalance fix is broken something. Investigating

@openshift-ci-robot
Copy link
Contributor

/hold

Revision bc69989 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 31, 2022
@marioferh
Copy link
Contributor

/retest-required

@openshift-ci-robot openshift-ci-robot mentioned this pull request Sep 1, 2022
Merged
@shajmakh
Copy link
Contributor

shajmakh commented Sep 1, 2022

/test e2e-gcp-pao

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 1, 2022

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-pao bc69989 link true /test e2e-gcp-pao

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

marioferh
marioferh reviewed Sep 2, 2022
View reviewed changes
Copy link
Contributor

@marioferh marioferh left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold
No changes in update profile and 4.11 is working right until now.
Unexpected error:

    <*errors.errorString | 0xc0003be2f0>: {
        s: "banned CPUs 4-7 do not match the expected mask  on node ci-op-3rtcp4mr-0cb17-sd8lm-worker-a-bj7fx",
    }
    banned CPUs 4-7 do not match the expected mask  on node ci-op-3rtcp4mr-0cb17-sd8lm-worker-a-bj7fx
occurred

ExpectedBannedCpus is empty

Also it should be rebase to the last 4.11, e.g. this patch its not included in this PR.
#435

@yanirq
Copy link
Contributor

yanirq commented Sep 4, 2022

/approve cancel
please rebase

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 4, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please assign yanirq for approval by writing /assign @yanirq in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2022
@shajmakh
Copy link
Contributor

shajmakh commented Sep 6, 2022

closing this PR in favor of #458 as it looked like #446 needed a rebase on the cherry-pick bot.
@yanirq I don't have permission to close a cherry-pick PR, could you do that on my behalf please?

@shajmakh shajmakh mentioned this pull request Sep 6, 2022
Merged
@yanirq
Copy link
Contributor

yanirq commented Sep 7, 2022

/close
in favor of #458

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 7, 2022

@yanirq: Closed this PR.

In response to this:

/close
in favor of #458

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot closed this Sep 7, 2022
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-63. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #429

/assign shajmakh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marioferh marioferh marioferh left review comments

@yanirq yanirq Awaiting requested review from yanirq

Assignees

@shajmakh shajmakh

Labels
backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@openshift-cherrypick-robot @shajmakh @openshift-ci-robot @yanirq @marioferh