[release-4.11] OCPBUGS-3015: Get latest profile before updating and use nodes.GetKubeletConfig #502

openshift-cherrypick-robot · 2022-11-01T11:09:29Z

This is an automated cherry-pick of #422

/assign mrniranjan

1. The tests fails when profile has machineconfig selector. Modified tests to have BeforeEach and AfterEach section where if mcp selector exists we removeit in BeforeEach section and restore it in AfterEach section 2. use variable of type func(Anonymous functions) to delete worker-test label and use the variable such that when testid: 27484 is called worker-test labels are removed and even when test is not called. The variable is called in AfterEach appropriately such that profile reverts back to its earlier configuration cleanly Signed-off-by: Niranjan M.R <mrniranjan@redhat.com>

openshift-ci-robot · 2022-11-01T11:09:35Z

@openshift-cherrypick-robot: Bugzilla Bug 2115802 has been cloned as Jira Issue OCPBUGS-3015. Retitling PR to link against new bug.
/retitle [release-4.11] OCPBUGS-3015: Get latest profile before updating and use nodes.GetKubeletConfig

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-11-01T11:09:42Z

@openshift-cherrypick-robot: An error was encountered cloning bug for cherrypick for bug 2115802 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message.


code 106: Sorry, entering a bug into the product OpenShift Container Platform has been disabled.

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-11-01T11:09:51Z

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2022-11-01T11:09:53Z

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-3015, which is invalid:

expected dependent Bugzilla Bug 2115802 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mrniranjan · 2022-11-01T14:36:05Z

/retest-required

mrniranjan · 2022-11-02T06:16:40Z

/retest-required

shajmakh · 2022-11-10T10:54:39Z

/jira refresh

openshift-ci-robot · 2022-11-10T10:54:42Z

@shajmakh: This pull request references Jira Issue OCPBUGS-3015, which is invalid:

expected dependent Bugzilla Bug 2115802 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

shajmakh · 2022-11-10T10:55:51Z

/jira refresh

openshift-ci-robot · 2022-11-10T10:55:55Z

@shajmakh: This pull request references Jira Issue OCPBUGS-3015, which is invalid:

bug is open, matching expected state (open)
bug target version (4.11.z) matches configured target version for branch (4.11.z)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
dependent Bugzilla Bug 2115802 targets the "4.12.0" version, which is one of the valid target versions: 4.12.0
bug has dependents
dependent bug OCPBUGSM-47739 is not in the required OCPBUGS project

All dependent bugs must be part of the OCPBUGS project. If you are backporting a fix that was originally tracked in Bugzilla, follow these steps to handle the backport:

Create a new bug in the OCPBUGS Jira project to match the original bugzilla bug. The important fields that should match are the title, description, target version, and status.
Use the Jira UI to clone the Jira bug, then in the clone bug:
a. Set the target version to the release you are cherrypicking to.
b. Add an issue link “is blocked by”, which links to the original jira bug
Use the cherrypick github command to create the cherrypicked PR. Once that new PR is created, retitle the PR and replace the BUG XXX: with OCPBUGS-XXX: to match the new Jira story.

Note that the mirrored bug in OCPBUGSM should not be involved in this process at all.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mrniranjan · 2022-11-10T11:08:31Z

/jira refresh

openshift-ci-robot · 2022-11-10T11:08:37Z

@mrniranjan: This pull request references Jira Issue OCPBUGS-3015, which is invalid:

bug is open, matching expected state (open)
bug target version (4.11.z) matches configured target version for branch (4.11.z)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
dependent Bugzilla Bug 2115802 targets the "4.12.0" version, which is one of the valid target versions: 4.12.0
bug has dependents
dependent bug OCPBUGSM-47739 is not in the required OCPBUGS project

All dependent bugs must be part of the OCPBUGS project. If you are backporting a fix that was originally tracked in Bugzilla, follow these steps to handle the backport:

Create a new bug in the OCPBUGS Jira project to match the original bugzilla bug. The important fields that should match are the title, description, target version, and status.
Use the Jira UI to clone the Jira bug, then in the clone bug:
a. Set the target version to the release you are cherrypicking to.
b. Add an issue link “is blocked by”, which links to the original jira bug
Use the cherrypick github command to create the cherrypicked PR. Once that new PR is created, retitle the PR and replace the BUG XXX: with OCPBUGS-XXX: to match the new Jira story.

Note that the mirrored bug in OCPBUGSM should not be involved in this process at all.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mrniranjan · 2022-11-10T11:12:38Z

/jira refresh

openshift-ci-robot · 2022-11-10T11:12:42Z

@mrniranjan: This pull request references Jira Issue OCPBUGS-3015, which is invalid:

expected dependent Jira Issue OCPBUGS-3483 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is New instead
expected dependent Bugzilla Bug 2115802 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mrniranjan · 2022-11-13T08:38:55Z

/jira refresh

openshift-ci-robot · 2022-11-13T08:38:59Z

@mrniranjan: This pull request references Jira Issue OCPBUGS-3015, which is invalid:

expected dependent Bugzilla Bug 2115802 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mrniranjan · 2022-11-13T08:41:04Z

/jira refresh

openshift-ci-robot · 2022-11-13T08:41:11Z

@mrniranjan: This pull request references Jira Issue OCPBUGS-3015, which is valid. The bug has been moved to the POST state.

8 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.11.z) matches configured target version for branch (4.11.z)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-3483 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
dependent bug Bugzilla Bug 2115802 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
dependent Jira Issue OCPBUGS-3483 targets the "4.12.0" version, which is one of the valid target versions: 4.12.0
dependent Bugzilla Bug 2115802 targets the "4.12.0" version, which is one of the valid target versions: 4.12.0
bug has dependents

Requesting review from QA contact:
/cc @gsr-shanks

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mrniranjan · 2022-11-14T09:17:48Z

/retest-required

mrniranjan · 2022-11-14T12:28:10Z

/retest-required

yanirq · 2022-11-14T14:11:55Z

/approve

yanirq · 2022-11-14T14:12:21Z

/label backport-risk-assessed

openshift-ci · 2022-11-14T14:13:19Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, yanirq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [yanirq]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

mrniranjan · 2022-11-15T09:10:09Z

/test e2e-gcp-pao

mrniranjan · 2022-11-22T12:22:45Z

/label cherry-pick-approved

mrniranjan · 2022-11-22T12:59:06Z

/lgtm

openshift-ci-robot · 2022-11-22T14:37:59Z

/retest-required

Remaining retests: 0 against base HEAD ecd98ea and 2 for PR HEAD eb76426 in total

mrniranjan · 2022-11-23T06:41:50Z

/retest-required

mrniranjan · 2022-11-23T09:56:00Z

/test e2e-gcp-pao

mrniranjan · 2022-11-23T14:14:52Z

/test e2e-gcp-pao

openshift-ci-robot · 2022-11-24T14:03:37Z

/retest-required

Remaining retests: 0 against base HEAD 9c8fd3d and 1 for PR HEAD eb76426 in total

openshift-ci-robot · 2022-11-24T19:06:03Z

/retest-required

Remaining retests: 0 against base HEAD 33eeb1b and 0 for PR HEAD eb76426 in total

openshift-ci-robot · 2022-11-24T23:05:53Z

/hold

Revision eb76426 was retested 3 times: holding

mrniranjan · 2022-11-25T06:53:00Z

/test e2e-gcp-pao

mrniranjan · 2022-11-29T01:21:02Z

/test e2e-gcp-pao

ffromani · 2022-11-29T13:21:41Z

/hold cancel

openshift-ci-robot · 2022-11-29T15:15:48Z

/retest-required

Remaining retests: 0 against base HEAD a5c1256 and 2 for PR HEAD eb76426 in total

ffromani · 2022-11-29T17:59:58Z

/retest

openshift-ci · 2022-11-29T20:15:17Z

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci-robot · 2022-11-29T20:18:20Z

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

openshift/cluster-node-tuning-operator#502

Jira Issue OCPBUGS-3015 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot mentioned this pull request Nov 1, 2022

Bug 2115802: Get latest profile before updating and use nodes.GetKubeletConfig #422

Merged

openshift-cherrypick-robot assigned mrniranjan Nov 1, 2022

openshift-ci bot changed the title ~~[release-4.11] Bug 2115802: Get latest profile before updating and use nodes.GetKubeletConfig~~ [release-4.11] OCPBUGS-3015: Get latest profile before updating and use nodes.GetKubeletConfig Nov 1, 2022

openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Nov 1, 2022

openshift-ci bot requested review from jlojosnegros and jmencak November 1, 2022 11:09

openshift-ci bot requested a review from gsr-shanks November 13, 2022 08:41

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Nov 14, 2022

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 14, 2022

openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 22, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 22, 2022

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 24, 2022

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 29, 2022

openshift-merge-robot merged commit 6f3d8ec into openshift:release-4.11 Nov 29, 2022

[release-4.11] OCPBUGS-3015: Get latest profile before updating and use nodes.GetKubeletConfig #502

[release-4.11] OCPBUGS-3015: Get latest profile before updating and use nodes.GetKubeletConfig #502

Conversation

openshift-cherrypick-robot commented Nov 1, 2022

openshift-ci-robot commented Nov 1, 2022

openshift-ci bot commented Nov 1, 2022

openshift-ci bot commented Nov 1, 2022

openshift-ci-robot commented Nov 1, 2022

mrniranjan commented Nov 1, 2022

mrniranjan commented Nov 2, 2022

shajmakh commented Nov 10, 2022

openshift-ci-robot commented Nov 10, 2022

shajmakh commented Nov 10, 2022

openshift-ci-robot commented Nov 10, 2022

mrniranjan commented Nov 10, 2022

openshift-ci-robot commented Nov 10, 2022

mrniranjan commented Nov 10, 2022

openshift-ci-robot commented Nov 10, 2022

mrniranjan commented Nov 13, 2022

openshift-ci-robot commented Nov 13, 2022

mrniranjan commented Nov 13, 2022

openshift-ci-robot commented Nov 13, 2022

mrniranjan commented Nov 14, 2022

mrniranjan commented Nov 14, 2022

yanirq commented Nov 14, 2022

yanirq commented Nov 14, 2022

openshift-ci bot commented Nov 14, 2022

mrniranjan commented Nov 15, 2022

mrniranjan commented Nov 22, 2022

mrniranjan commented Nov 22, 2022

openshift-ci-robot commented Nov 22, 2022

mrniranjan commented Nov 23, 2022

mrniranjan commented Nov 23, 2022

mrniranjan commented Nov 23, 2022

openshift-ci-robot commented Nov 24, 2022

openshift-ci-robot commented Nov 24, 2022

openshift-ci-robot commented Nov 24, 2022

mrniranjan commented Nov 25, 2022

mrniranjan commented Nov 29, 2022

ffromani commented Nov 29, 2022

openshift-ci-robot commented Nov 29, 2022

ffromani commented Nov 29, 2022

openshift-ci bot commented Nov 29, 2022

openshift-ci-robot commented Nov 29, 2022