Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.11] OCPBUGS-3474: Add ktimer to PAO tuned profile #510

Merged

Conversation

jlojosnegros
Copy link
Contributor

Backport of #507 to release-4.11

/hold

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 10, 2022

@jlojosnegros: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Add ktimer to PAO tuned profile

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 10, 2022
@jlojosnegros jlojosnegros changed the title Add ktimer to PAO tuned profile OCPBUGS-3474: Add ktimer to PAO tuned profile Nov 10, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 10, 2022

@jlojosnegros: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

OCPBUGS-3474: Add ktimer to PAO tuned profile

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 10, 2022
@openshift-ci-robot
Copy link
Contributor

@jlojosnegros: This pull request references Jira Issue OCPBUGS-3474, which is invalid:

  • expected the bug to target the "4.11.z" version, but it targets "4.11.0" instead
  • expected Jira Issue OCPBUGS-3474 to depend on a bug targeting a version in 4.12.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Backport of #507 to release-4.11

/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jlojosnegros jlojosnegros changed the title OCPBUGS-3474: Add ktimer to PAO tuned profile [release-4.11] OCPBUGS-3474: Add ktimer to PAO tuned profile Nov 10, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 10, 2022

@jlojosnegros: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.11] OCPBUGS-3474: Add ktimer to PAO tuned profile

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jlojosnegros
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@jlojosnegros: This pull request references Jira Issue OCPBUGS-3474, which is invalid:

  • expected dependent Jira Issue OCPBUGS-3475 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jlojosnegros
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 10, 2022
@jlojosnegros
Copy link
Contributor Author

/test e2e-aws

@jlojosnegros
Copy link
Contributor Author

/cherry-pick release-4.10

@openshift-cherrypick-robot

@jlojosnegros: once the present PR merges, I will cherry-pick it on top of release-4.10 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jlojosnegros
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@jlojosnegros: This pull request references Jira Issue OCPBUGS-3474, which is invalid:

  • expected dependent Jira Issue OCPBUGS-3475 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jlojosnegros
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@jlojosnegros: This pull request references Jira Issue OCPBUGS-3474, which is invalid:

  • expected dependent Jira Issue OCPBUGS-3475 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jlojosnegros
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Nov 21, 2022
@openshift-ci-robot
Copy link
Contributor

@jlojosnegros: This pull request references Jira Issue OCPBUGS-3474, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.11.z) matches configured target version for branch (4.11.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-3475 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-3475 targets the "4.12.0" version, which is one of the valid target versions: 4.12.0
  • bug has dependents

Requesting review from QA contact:
/cc @gsr-shanks

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Nov 21, 2022
@MarSik
Copy link
Contributor

MarSik commented Nov 22, 2022

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Nov 22, 2022
@yanirq
Copy link
Contributor

yanirq commented Nov 22, 2022

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 22, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 22, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlojosnegros, yanirq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2022
@shajmakh
Copy link
Contributor

/label cherry-pick-approved
cc @mrniranjan

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 22, 2022
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD ecd98ea and 2 for PR HEAD 90b64da in total

@jlojosnegros
Copy link
Contributor Author

/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 9c8fd3d and 1 for PR HEAD 90b64da in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 24, 2022

@jlojosnegros: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 33eeb1b into openshift:release-4.11 Nov 24, 2022
@openshift-ci-robot
Copy link
Contributor

@jlojosnegros: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-3474 has been moved to the MODIFIED state.

In response to this:

Backport of #507 to release-4.11

/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@jlojosnegros: #510 failed to apply on top of branch "release-4.10":

Applying: Add ktimer to PAO tuned profile
Using index info to reconstruct a base tree...
A	assets/performanceprofile/tuned/openshift-node-performance
A	pkg/performanceprofile/controller/performanceprofile/components/tuned/tuned_test.go
A	test/e2e/performanceprofile/testdata/render-expected-output/manual_tuned.yaml
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): test/e2e/performanceprofile/testdata/render-expected-output/manual_tuned.yaml deleted in HEAD and modified in Add ktimer to PAO tuned profile. Version Add ktimer to PAO tuned profile of test/e2e/performanceprofile/testdata/render-expected-output/manual_tuned.yaml left in tree.
CONFLICT (modify/delete): pkg/performanceprofile/controller/performanceprofile/components/tuned/tuned_test.go deleted in HEAD and modified in Add ktimer to PAO tuned profile. Version Add ktimer to PAO tuned profile of pkg/performanceprofile/controller/performanceprofile/components/tuned/tuned_test.go left in tree.
CONFLICT (modify/delete): assets/performanceprofile/tuned/openshift-node-performance deleted in HEAD and modified in Add ktimer to PAO tuned profile. Version Add ktimer to PAO tuned profile of assets/performanceprofile/tuned/openshift-node-performance left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Add ktimer to PAO tuned profile
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants