Remove pkg/manifests/bindata.go from the repo, generate it. #54
Conversation
openshift-ci-robot
added
approved
This is a Makefile cleanup PR. File pkg/manifests/bindata.go is removed from the repository as it was leading to issues as in PR52, where old bindata.go files were being shipped with modified resources.
|
/lgtm Talked to @jmencak about this today and rather than carrying the generated bindata and a script to update it we're just going to generate it as part of the build process. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jmencak, sjug The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherrypick release-4.1 |
|
@jmencak: new pull request created: #56 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is a Makefile cleanup PR. File pkg/manifests/bindata.go
is removed from the repository as it was leading to issues as in #52,
where old bindata.go files were being shipped with modified resources.