[release-4.13][manual] OCPBUGS-11851: render: remove uid from render-sync target (#594) #609
Conversation
The render command is generating manifests with uid now. we don't need it to be part of the data for our render-expected-output so let's remove it Signed-off-by: Talor Itzhak <titzhak@redhat.com>
|
@ffromani: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ffromani The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/override ci/prow/e2e-gcp-pao known issue |
|
@ffromani: Overrode contexts on behalf of ffromani: ci/prow/e2e-gcp-pao In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest-required |
| @@ -9,4 +9,8 @@ _output/cluster-node-tuning-operator render \ | |||
| --asset-output-dir "${ARTIFACT_DIR}" | |||
|
|
|||
| cp "${ARTIFACT_DIR}"/* "${WORKDIR}"/test/e2e/performanceprofile/testdata/render-expected-output | |||
| for f in "${WORKDIR}"/test/e2e/performanceprofile/testdata/render-expected-output/* | |||
There was a problem hiding this comment.
Nit: two spaces between in "${WOR
| @@ -9,4 +9,8 @@ _output/cluster-node-tuning-operator render \ | |||
| --asset-output-dir "${ARTIFACT_DIR}" | |||
|
|
|||
| cp "${ARTIFACT_DIR}"/* "${WORKDIR}"/test/e2e/performanceprofile/testdata/render-expected-output | |||
| for f in "${WORKDIR}"/test/e2e/performanceprofile/testdata/render-expected-output/* | |||
| do | |||
| sed -i "s/uid:.*/uid: \"\"/" "${f}" | |||
There was a problem hiding this comment.
Nit: For some, I believe sed -i 's/uid:.*/uid: ""/' "${f}" would be easier to read.
There was a problem hiding this comment.
AFAIR using single quotes (') ignores regex this is why we use double quotes (") here
Since this is a manual backport I can fix master branch first and then update this PR I guess |
I think I can live with the current state. |
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold cancel thanks Jiri. Unholding since we missing required labels anyway |
openshift-ci
bot
removed
the
do-not-merge/hold
|
@ffromani we will need a bug to get this merged |
|
/retitle [release-4.13][manual] OCPBUGS-11851: render: remove uid from render-sync target (#594) |
openshift-ci
bot
changed the title
|
@ffromani: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
@ffromani: This pull request references Jira Issue OCPBUGS-11851, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
jira/invalid-bug
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@Tal-or: This pull request references Jira Issue OCPBUGS-11851, which is valid. The bug has been moved to the POST state. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
removed
the
jira/invalid-bug
|
/label backport-risk-assessed |
openshift-ci
bot
added
the
backport-risk-assessed
|
@mrniranjan please review for the cherrypick approve label |
|
/label cherry-pick-approved |
openshift-ci
bot
added
the
cherry-pick-approved
|
/hold Revision 288f938 was retested 3 times: holding |
openshift-ci
bot
added
the
do-not-merge/hold
|
depends on #604 which fixes the broken |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/test e2e-gcp-pao-updating-profile |
|
/hold Revision 288f938 was retested 3 times: holding |
openshift-ci
bot
added
the
do-not-merge/hold
|
/retest |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
@ffromani: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
openshift-merge-robot
merged commit fdc0840
into
openshift:release-4.13
|
@ffromani: Jira Issue OCPBUGS-11851: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-11851 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The render command is generating manifests with uid now. we don't need it to be part of the data for our render-expected-output so let's remove it