Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-13148: Configure cpu balancing cpu sets for all clusters #646

Merged

Conversation

MarSik
Copy link
Contributor

@MarSik MarSik commented May 5, 2023

The current code configures the cpu balancing management cpuset cgroup structure only when Workload partitioning is enabled.

That is wrong as even standard clusters use that feature.

@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 5, 2023
@openshift-ci-robot
Copy link
Contributor

@MarSik: This pull request references Jira Issue OCPBUGS-13148, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

The current code configures the cpu balancing management cpuset cgroup structure only when Workload partitioning is enabled.

That is wrong as even standard clusters use that feature.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MarSik
Copy link
Contributor Author

MarSik commented May 5, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 5, 2023
@openshift-ci-robot
Copy link
Contributor

@MarSik: This pull request references Jira Issue OCPBUGS-13148, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gsr-shanks

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MarSik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 5, 2023
@MarSik MarSik force-pushed the fix-cgroupv1-non-sno branch 2 times, most recently from 78193a6 to ec26641 Compare May 5, 2023 09:44
The current code configures the cpu balancing management cpuset
cgroup structure only when Workload partitioning is enabled.

That is wrong as even standard clusters use that feature.
@browsell
Copy link
Contributor

browsell commented May 5, 2023

LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 5, 2023

@MarSik: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@ffromani ffromani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 5, 2023
@MarSik
Copy link
Contributor Author

MarSik commented May 5, 2023

/cherry-pick release-4.13

@openshift-cherrypick-robot

@MarSik: once the present PR merges, I will cherry-pick it on top of release-4.13 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit f846d73 into openshift:master May 5, 2023
11 checks passed
@openshift-ci-robot
Copy link
Contributor

@MarSik: Jira Issue OCPBUGS-13148: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-13148 has been moved to the MODIFIED state.

In response to this:

The current code configures the cpu balancing management cpuset cgroup structure only when Workload partitioning is enabled.

That is wrong as even standard clusters use that feature.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@MarSik: new pull request created: #647

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

IlyaTyomkin pushed a commit to IlyaTyomkin/cluster-node-tuning-operator that referenced this pull request May 17, 2023
…nshift#646)

The current code configures the cpu balancing management cpuset
cgroup structure only when Workload partitioning is enabled.

That is wrong as even standard clusters use that feature.

Add PerformanceProfiles to 'oc adm must-gather' (openshift#582)

Add PerformanceProfiles as a RelatedObject for the must-gather tool.

Co-authored-by: Jiri Mencak <jmencak@users.noreply.github.com>

Signed-off-by: Ilya Tyomkin <ityomkin@ityomkin.remote.csb>

Latency 200

Latency 200

Signed-off-by: Ilya Tyomkin <ityomkin@ityomkin.remote.csb>

latency 200

Focused on one test

Aligned Structure with other
IlyaTyomkin pushed a commit to IlyaTyomkin/cluster-node-tuning-operator that referenced this pull request May 18, 2023
…nshift#646)

The current code configures the cpu balancing management cpuset
cgroup structure only when Workload partitioning is enabled.

That is wrong as even standard clusters use that feature.

Add PerformanceProfiles to 'oc adm must-gather' (openshift#582)

Add PerformanceProfiles as a RelatedObject for the must-gather tool.

Co-authored-by: Jiri Mencak <jmencak@users.noreply.github.com>

Signed-off-by: Ilya Tyomkin <ityomkin@ityomkin.remote.csb>

Latency 200

Latency 200

Signed-off-by: Ilya Tyomkin <ityomkin@ityomkin.remote.csb>

latency 200

Focused on one test

Aligned Structure with other
IlyaTyomkin pushed a commit to IlyaTyomkin/cluster-node-tuning-operator that referenced this pull request May 21, 2023
…nshift#646)

The current code configures the cpu balancing management cpuset
cgroup structure only when Workload partitioning is enabled.

That is wrong as even standard clusters use that feature.

Add PerformanceProfiles to 'oc adm must-gather' (openshift#582)

Add PerformanceProfiles as a RelatedObject for the must-gather tool.

Co-authored-by: Jiri Mencak <jmencak@users.noreply.github.com>

Signed-off-by: Ilya Tyomkin <ityomkin@ityomkin.remote.csb>

Latency 200

Latency 200

Signed-off-by: Ilya Tyomkin <ityomkin@ityomkin.remote.csb>

latency 200

Focused on one test

Aligned Structure with other

launch oslat only with latency 200

Launch cyclictest only

Another launch of cyclictest

Launch cyclictest without latency=200 parameter

Launch hwlatdetect only with latency = 200

Cancellation of all limitations for tests to launch
IlyaTyomkin pushed a commit to IlyaTyomkin/cluster-node-tuning-operator that referenced this pull request May 23, 2023
…nshift#646)

The current code configures the cpu balancing management cpuset
cgroup structure only when Workload partitioning is enabled.

That is wrong as even standard clusters use that feature.
IlyaTyomkin pushed a commit to IlyaTyomkin/cluster-node-tuning-operator that referenced this pull request Jun 13, 2023
…nshift#646)

The current code configures the cpu balancing management cpuset
cgroup structure only when Workload partitioning is enabled.

That is wrong as even standard clusters use that feature.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants