Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose TuneD socket to host. #651

Conversation

jmencak
Copy link
Contributor

@jmencak jmencak commented May 15, 2023

This change exposes TuneD socket interface to the host OS. This will, for example, allow to query and/or change a TuneD profile by using TuneD socket API. For example, issuing the following (by the root user) from the host will return the active TuneD profile.

printf '{"jsonrpc": "2.0", "method": "active_profile", "id": 1}' | nc -U /run/tuned/tuned.sock
{"jsonrpc": "2.0", "id": 1, "result": "openshift-node"}

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmencak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2023
@jmencak
Copy link
Contributor Author

jmencak commented May 15, 2023

/assign @dagrayvid

@jmencak
Copy link
Contributor Author

jmencak commented May 15, 2023

/hold
This needs a bit of cleanup.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 15, 2023
This change exposes TuneD socket interface to the host OS.  This will,
for example, allow to query and/or change a TuneD profile by using TuneD
socket API.  For example, issuing the following will return the active
TuneD profile.

printf '{"jsonrpc": "2.0", "method": "active_profile", "id": 1}' | nc -U /run/tuned/tuned.sock
{"jsonrpc": "2.0", "id": 1, "result": "openshift-node"}
@jmencak jmencak force-pushed the 4.14-psap-945-expose-tuned-socket branch from 3110882 to 35f817b Compare May 15, 2023 18:41
@jmencak
Copy link
Contributor Author

jmencak commented May 15, 2023

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 15, 2023
@dagrayvid
Copy link
Contributor

Thanks @jmencak, this change looks good to me now.

@jmencak
Copy link
Contributor Author

jmencak commented May 16, 2023

/retest

@liqcui
Copy link

liqcui commented May 17, 2023

Pre-merge Testing Done, Looks good to me

@jmencak
Copy link
Contributor Author

jmencak commented May 17, 2023

Thank you guys. Can we get the LGTM label then?

@liqcui
Copy link

liqcui commented May 17, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 7654a51 and 2 for PR HEAD 35f817b in total

@jmencak
Copy link
Contributor Author

jmencak commented Jun 19, 2023

/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD d30c5cc and 1 for PR HEAD 35f817b in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 606c1b7 and 0 for PR HEAD 35f817b in total

@openshift-ci-robot
Copy link
Contributor

/hold

Revision 35f817b was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 19, 2023
@jmencak
Copy link
Contributor Author

jmencak commented Jun 19, 2023

/joke
/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 19, 2023

@jmencak: What do you call a dad that has fallen through the ice? A Popsicle.

In response to this:

/joke
/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jmencak
Copy link
Contributor Author

jmencak commented Jun 21, 2023

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 21, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD ea42679 and 2 for PR HEAD 35f817b in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 21, 2023

@jmencak: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit ea1d984 into openshift:master Jun 21, 2023
13 checks passed
@jmencak jmencak deleted the 4.14-psap-945-expose-tuned-socket branch June 21, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants