New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose TuneD socket to host. #651
Expose TuneD socket to host. #651
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jmencak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @dagrayvid |
/hold |
This change exposes TuneD socket interface to the host OS. This will, for example, allow to query and/or change a TuneD profile by using TuneD socket API. For example, issuing the following will return the active TuneD profile. printf '{"jsonrpc": "2.0", "method": "active_profile", "id": 1}' | nc -U /run/tuned/tuned.sock {"jsonrpc": "2.0", "id": 1, "result": "openshift-node"}
3110882
to
35f817b
Compare
/unhold |
Thanks @jmencak, this change looks good to me now. |
/retest |
Pre-merge Testing Done, Looks good to me |
Thank you guys. Can we get the LGTM label then? |
/lgtm |
/retest |
/hold Revision 35f817b was retested 3 times: holding |
/joke |
@jmencak: What do you call a dad that has fallen through the ice? A Popsicle. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/unhold |
@jmencak: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This change exposes
TuneD
socket interface to the host OS. This will, for example, allow to query and/or change aTuneD
profile by usingTuneD
socket API. For example, issuing the following (by the root user) from the host will return the activeTuneD
profile.