test: perfprof: devices: fix default test image #672
Conversation
The new test image gained compatibility with SRIOV device plugin >= 4.13 Signed-off-by: Francesco Romani <fromani@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ffromani The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
| @@ -34,7 +34,7 @@ const ( | |||
|
|
|||
| // note NO DEFAULT for targetNode - intentionally | |||
| sriovDeviceResourceNameDefault = "openshift.io/dpdk_nic_1" | |||
| workloadContainerImageDefault = "quay.io/fromani/devaccess:2023051001" // FIXME | |||
| workloadContainerImageDefault = "quay.io/fromani/devaccess:2023060101" // FIXME | |||
There was a problem hiding this comment.
Thanks for the PR. Are we generally fine using images from private registries ("fromani") in the tests?
There was a problem hiding this comment.
no we're not. I'm bending the rules, this is barely OK, but I don't have the capacity to do anything better atm.
There was a problem hiding this comment.
I see. Thanks for clarifying.
|
/lgtm |
|
@ffromani: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
The new test image gained compatibility with SRIOV device plugin >= 4.13