OCPBUGS-14934: consistent use of ginkgo flags in Makefile #682
Conversation
Also pass --junit-report=report.xml with other ginkgo options instead of passing with -r Signed-off-by: Niranjan M.R <mrniranjan@redhat.com>
mrniranjan
force-pushed
the
minor_makefile_fix
branch
from
e22e52a
to
83aeab0
Compare
mrniranjan
changed the title
Makefile
Outdated
| @@ -208,7 +208,7 @@ pao-functests-updating-profile: cluster-label-worker-cnf pao-functests-update-on | |||
| pao-functests-update-only: | |||
| @echo "Cluster Version" | |||
| hack/show-cluster-version.sh | |||
| hack/run-test.sh -t "test/e2e/performanceprofile/functests/0_config test/e2e/performanceprofile/functests/2_performance_update test/e2e/performanceprofile/functests/3_performance_status test/e2e/performanceprofile/functests/7_performance_kubelet_node test/e2e/performanceprofile/functests/8_reboot" -p "-v -r -timeout=5h --fail-fast --flake-attempts=2" -m "Running Functional Tests" -r "--junit-report=report.xml" | |||
| hack/run-test.sh -t "test/e2e/performanceprofile/functests/0_config test/e2e/performanceprofile/functests/2_performance_update test/e2e/performanceprofile/functests/3_performance_status test/e2e/performanceprofile/functests/7_performance_kubelet_node test/e2e/performanceprofile/functests/8_reboot" -p "--v -r -timeout=5h --fail-fast --flake-attempts=2 --junit-report=report.xml" -m "Running Functional Tests" | |||
There was a problem hiding this comment.
fixed in the latest commit
Signed-off-by: Niranjan M.R <mrniranjan@redhat.com>
Signed-off-by: Niranjan M.R <mrniranjan@redhat.com>
Signed-off-by: Niranjan M.R <mrniranjan@redhat.com>
Makefile
Outdated
| @@ -217,13 +217,13 @@ pao-functests-performance-workloadhints: cluster-label-worker-cnf pao-functests- | |||
| pao-functests-performance-workloadhints-only: | |||
| @echo "Cluster Version" | |||
| hack/show-cluster-version.sh | |||
| hack/run-test.sh -t "test/e2e/performanceprofile/functests/0_config test/e2e/performanceprofile/functests/8_performance_workloadhints" -p "-v -r -timeout=5h --fail-fast --flake-attempts=2" -m "Running Functional WorkloadHints Tests" -r "--junit-report=report.xml" | |||
| hack/run-test.sh -t "test/e2e/performanceprofile/functests/0_config test/e2e/performanceprofile/functests/8_performance_workloadhints" -p "--v -r --fail-fast --flake-attempts=2 -timeout=5h --junit-report=report.xml" -m "Running Functional WorkloadHints Tests" | |||
There was a problem hiding this comment.
what is the semantics of "-r"?
There was a problem hiding this comment.
Report parameters where positioned after the required test suites in the original scripts.
When I wrote them with the rest of parameters it did not work for me, so I added a different parameter in the script to be able to write them after the suites as in the original.
|
/approve I like the general direction |
|
/cc @jlojosnegros |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ffromani, mrniranjan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Makefile
Outdated
| @@ -208,7 +208,7 @@ pao-functests-updating-profile: cluster-label-worker-cnf pao-functests-update-on | |||
| pao-functests-update-only: | |||
| @echo "Cluster Version" | |||
| hack/show-cluster-version.sh | |||
| hack/run-test.sh -t "test/e2e/performanceprofile/functests/0_config test/e2e/performanceprofile/functests/2_performance_update test/e2e/performanceprofile/functests/3_performance_status test/e2e/performanceprofile/functests/7_performance_kubelet_node test/e2e/performanceprofile/functests/8_reboot" -p "--v -r -timeout=5h --fail-fast --flake-attempts=2 --junit-report=report.xml" -m "Running Functional Tests" | |||
| hack/run-test.sh -t "test/e2e/performanceprofile/functests/0_config test/e2e/performanceprofile/functests/2_performance_update test/e2e/performanceprofile/functests/3_performance_status test/e2e/performanceprofile/functests/7_performance_kubelet_node test/e2e/performanceprofile/functests/8_reboot" -p "--v -r --fail-fast --flake-attempts=2 --timeout=5h --junit-report=report.xml" -m "Running Functional Tests" | |||
There was a problem hiding this comment.
Why the double - in timeout?
and the change in order?
There was a problem hiding this comment.
i am just going by ginkgo run --options,
Debugging Tests
In addition to these flags, Ginkgo supports a few debugging environment
variables. To change the parallel server protocol set GINKGO_PARALLEL_PROTOCOL
to HTTP. To avoid pruning callstacks set GINKGO_PRUNE_STACK to FALSE.
--dry-run
If set, ginkgo will walk the test hierarchy without actually running
anything. Best paired with -v.
--progress
If set, ginkgo will emit progress information as each spec runs to the
GinkgoWriter.
--timeout [duration] (default: 1h)
Test suite fails if it does not complete within the specified timeout.
--output-interceptor-mode [dup, swap, or none]
If set, ginkgo will use the specified output interception strategy when
running in parallel. Defaults to dup on unix and swap on windows.
--until-it-fails
If set, ginkgo will keep rerunning test suites until a failure occurs.
--repeat [n] (default: 0 - i.e. no repetition, run only once)
The number of times to re-run a test-suite. Useful for debugging flaky
tests. If set to N the suite will be run N+1 times and will be required to
pass each time.
|
/lgtm |
|
/test e2e-gcp-pao |
|
/test e2e-gcp-pao-updating-profile |
|
/retest-required |
mrniranjan
changed the title
openshift-ci-robot
added
jira/severity-moderate
|
@mrniranjan: This pull request references Jira Issue OCPBUGS-14934, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (nkononov@redhat.com), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest-required |
|
@mrniranjan: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@mrniranjan: Jira Issue OCPBUGS-14934: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-14934 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
consistent use of ginkgo flags in Makefile
Also pass --junit-report=report.xml with other ginkgo options instead of passing with -r