Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-12836: [pao] [e2e] flaky test test_id:28440 Updating of nodeSelector #690

Merged

Conversation

jlojosnegros
Copy link
Contributor

@jlojosnegros jlojosnegros commented Jun 20, 2023

Just enable the tests to check if, after the ci-lane split they work, as the lastest errors were due to timeout issues.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 20, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 20, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@jlojosnegros
Copy link
Contributor Author

/test all

@jlojosnegros
Copy link
Contributor Author

/retitle OCPBUGS-12836: [pao] [e2e] flaky test test_id:28440 Updating of nodeSelector

@openshift-ci openshift-ci bot changed the title pao e2e flaky test test_id:28440 Updating of nodeSelector OCPBUGS-12836: [pao] [e2e] flaky test test_id:28440 Updating of nodeSelector Jun 20, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 20, 2023
@openshift-ci-robot
Copy link
Contributor

@jlojosnegros: This pull request references Jira Issue OCPBUGS-12836, which is invalid:

  • expected the bug to target the "4.14.0" version, but it targets "4.14" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jlojosnegros
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@jlojosnegros: This pull request references Jira Issue OCPBUGS-12836, which is invalid:

  • expected the bug to target the "4.14.0" version, but it targets "4.14" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jlojosnegros
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@jlojosnegros: This pull request references Jira Issue OCPBUGS-12836, which is invalid:

  • expected the bug to target the "4.14.0" version, but it targets "4.14" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jlojosnegros
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@jlojosnegros: This pull request references Jira Issue OCPBUGS-12836, which is invalid:

  • expected the bug to target the "4.14.0" version, but it targets "4.14" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jlojosnegros
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@jlojosnegros: This pull request references Jira Issue OCPBUGS-12836, which is invalid:

  • expected the bug to target the "4.14.0" version, but it targets "4.14" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jlojosnegros
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@jlojosnegros: This pull request references Jira Issue OCPBUGS-12836, which is invalid:

  • expected the bug to target the "4.14.0" version, but it targets "4.14" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jlojosnegros
Copy link
Contributor Author

/retest-required

@jlojosnegros
Copy link
Contributor Author

/retest required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 21, 2023

@jlojosnegros: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test e2e-aws-operator
  • /test e2e-aws-ovn
  • /test e2e-gcp-pao
  • /test e2e-gcp-pao-updating-profile
  • /test e2e-gcp-pao-workloadhints
  • /test e2e-hypershift
  • /test e2e-no-cluster
  • /test e2e-upgrade
  • /test images
  • /test unit
  • /test verify
  • /test vet

Use /test all to run all jobs.

In response to this:

/retest required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jlojosnegros
Copy link
Contributor Author

/test e2e-hypershift

@jlojosnegros
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 21, 2023
@openshift-ci-robot
Copy link
Contributor

@jlojosnegros: This pull request references Jira Issue OCPBUGS-12836, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (nkononov@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@jlojosnegros: This pull request references Jira Issue OCPBUGS-12836, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (nkononov@redhat.com), skipping review request.

In response to this:

Just enable the tests to check if, after the ci-lane split they work, as the lastest errors were due to timeout issues.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jlojosnegros jlojosnegros marked this pull request as ready for review June 21, 2023 09:17
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 21, 2023
@openshift-ci openshift-ci bot requested a review from Tal-or June 21, 2023 09:17
@openshift-ci openshift-ci bot requested a review from yanirq June 21, 2023 09:17
@jlojosnegros
Copy link
Contributor Author

/retest

@jlojosnegros
Copy link
Contributor Author

/test e2e-upgrade

@yanirq
Copy link
Contributor

yanirq commented Jun 22, 2023

if everything passes in multiple runs without any flakes we can remove the comment completely

@jlojosnegros
Copy link
Contributor Author

/test all

@jlojosnegros
Copy link
Contributor Author

infra failure
/test e2e-aws-ovn

@jlojosnegros
Copy link
Contributor Author

/test all

@jlojosnegros
Copy link
Contributor Author

this test suite has nothing to do with the test problem...
/test e2e-hypershift

@jlojosnegros
Copy link
Contributor Author

I have run all test three times with no failures related to the test itself. (some infra problems)
Rebasing over last master commit and deleting the commented code.

@jlojosnegros
Copy link
Contributor Author

Failed on install step not related to the bug

/test e2e-gcp-pao

@jlojosnegros
Copy link
Contributor Author

aws infra problem.
/test e2e-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 26, 2023

@jlojosnegros: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jlojosnegros
Copy link
Contributor Author

@yanirq PTAL and check if the last results are enough to accept this PR .

Thanks in advance

@yanirq
Copy link
Contributor

yanirq commented Jun 26, 2023

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlojosnegros, yanirq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2023
@openshift-merge-robot openshift-merge-robot merged commit a55aa92 into openshift:master Jun 26, 2023
13 checks passed
@openshift-ci-robot
Copy link
Contributor

@jlojosnegros: Jira Issue OCPBUGS-12836: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-12836 has been moved to the MODIFIED state.

In response to this:

Just enable the tests to check if, after the ci-lane split they work, as the lastest errors were due to timeout issues.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants