OCPBUGS-13065: Do not rollback settings on TuneD exit #699
Conversation
Settings rollbacks on TuneD exit in the OCP environment are generally a
bad idea. They can cause issues ranging from latency spikes to a
complete loss of service (see OCPBUGS-13065). Do not perform rollbacks
apart from when switching Profiles.
Other changes:
- Changed "rollback.go" e2e tests to reflect the new "rollback=not_on_exit"
behaviour.
Resolves: OCPBUGS-13065
openshift-ci-robot
added
jira/severity-critical
|
@jmencak: This pull request references Jira Issue OCPBUGS-13065, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (liqcui@redhat.com), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
jira/valid-bug
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jmencak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest |
|
@liqcui , just FYI if you want to do any pre-merge testing for this to validate OCPBUGS-13065 is fixed. |
|
/lgtm Pre-merge testing passed, compared with 4.11.44, the sysctl settings rollback to default value in 4.11.44, but new PR code didn't rollback. work as expect |
|
/retest |
|
This test already passed with this PR: /override ci/prow/e2e-hypershift |
|
@jmencak: Overrode contexts on behalf of jmencak: ci/prow/e2e-hypershift In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@jmencak: Jira Issue OCPBUGS-13065: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-13065 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@jmencak: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Settings rollbacks on
TuneDexit in the OCP environment are generally a bad idea. They can cause issues ranging from latency spikes to a complete loss of service (see OCPBUGS-13065). Do not perform rollbacks apart from when switching Profiles.Other changes:
rollback.goe2e tests to reflect the newrollback=not_on_exitbehaviour.rollback.go.Resolves: OCPBUGS-13065