[release-4.12] OCPBUGS-15803: Do not rollback settings on TuneD exit #711
Conversation
Settings rollbacks on TuneD exit in the OCP environment are generally a
bad idea. They can cause issues ranging from latency spikes to a
complete loss of service (see OCPBUGS-13065). Do not perform rollbacks
apart from when switching Profiles.
Other changes:
- Changed "rollback.go" e2e tests to reflect the new "rollback=not_on_exit"
behaviour.
Resolves: OCPBUGS-15736
Co-authored-by: Jiri Mencak <jmencak@users.noreply.github.com>
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-15736 has been cloned as Jira Issue OCPBUGS-15803. Will retitle bug to link to clone. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
changed the title
openshift-ci-robot
added
jira/severity-critical
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-15803, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@jmencak: This pull request references Jira Issue OCPBUGS-15803, which is valid. The bug has been moved to the POST state. 6 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (liqcui@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jmencak, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/label backport-risk-assessed |
openshift-ci
bot
added
the
backport-risk-assessed
|
/lgtm |
|
/label cherry-pick-approved |
openshift-ci
bot
added
the
cherry-pick-approved
|
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
openshift-merge-robot
merged commit f03097c
into
openshift:release-4.12
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-15803: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-15803 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.11 |
|
@jmencak: new pull request created: #715 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #704
/assign jmencak