Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build gather-sysinfo #714

Merged
merged 2 commits into from Jul 10, 2023
Merged

Build gather-sysinfo #714

merged 2 commits into from Jul 10, 2023

Conversation

MarSik
Copy link
Contributor

@MarSik MarSik commented Jul 7, 2023 •
edited

The gather-sysinfo binary is used by must-gather to collect
structured hardware information data about an OCP node.

This data is then also used by the Performance Profile Creator
also present in this repository.

Must-gather also needs the lspci binary from the pciutils package.

@openshift-ci openshift-ci bot requested review from ffromani and kpouget July 7, 2023 09:04
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MarSik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2023
ffromani
ffromani reviewed Jul 7, 2023
View reviewed changes
Copy link
Contributor

@ffromani ffromani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

importing gather-sysinfo into the tree may and should be the chance for a good and long-needed cleanup, but I guess we don't have time/capacity for that, do we?

cmd/gather-sysinfo/gather-sysinfo_suite_test.go Outdated Show resolved Hide resolved
cmd/gather-sysinfo/gather-sysinfo_test.go Outdated Show resolved Hide resolved
ffromani
ffromani reviewed Jul 7, 2023
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@ffromani
Copy link
Contributor

ffromani commented Jul 7, 2023

thanks for the updates! next time I recommend considering a verbatim import + fixing in the subsequent commits in order to preserve a good audit trail. In some cases this is unpractical but in this case it could have been.

ffromani
ffromani reviewed Jul 7, 2023
View reviewed changes
cmd/gather-sysinfo/gather-sysinfo.go Outdated Show resolved Hide resolved
cmd/gather-sysinfo/gather-sysinfo.go Outdated Show resolved Hide resolved
cmd/gather-sysinfo/gather-sysinfo_test.go Outdated Show resolved Hide resolved
cmd/gather-sysinfo/gather-sysinfo_test.go Outdated Show resolved Hide resolved
@MarSik MarSik force-pushed the feat-ocp-must-gather branch 2 times, most recently from 8037f9d to e53bbff Compare July 7, 2023 14:23
@MarSik MarSik mentioned this pull request Jul 7, 2023
Merged
@MarSik
Copy link
Contributor Author

MarSik commented Jul 7, 2023

/retest-required

jmencak
jmencak reviewed Jul 10, 2023
View reviewed changes
Copy link
Contributor

@jmencak jmencak left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes overall seem fine, but it is not clear to me how the collected information gets into must-gather. The commit message only states:

The gather-sysinfo binary is used by must-gather to collect
structured hardware information data about an OCP node.

Can you expand on that a bit how must-gather gets that information? Perhaps even in the commit message? Saw some nits so I pointed them out.

Edit: Oh, I missed openshift/must-gather#345 ... So my question is answered then.

cmd/gather-sysinfo/.gitignore Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@MarSik
Build gather-sysinfo and add pciutils
8cfce11 
The gather-sysinfo binary is used by must-gather to collect
structured hardware information data about an OCP node.

This data is then also used by the Performance Profile Creator
also present in this repository.

A pciutils package is also added to the final NTO image,
because it contains the lspci tool the must-gather script
requires.
@MarSik
Sync the vendor directory
dbd4d2f
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 10, 2023

@MarSik: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jmencak
Copy link
Contributor

jmencak commented Jul 10, 2023

Thank you for the changes and the PR, looking forward to future customer's must-gathers.
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2023
@openshift-merge-robot openshift-merge-robot merged commit 4414b0d into openshift:master Jul 10, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmencak jmencak jmencak left review comments

@jlojosnegros jlojosnegros jlojosnegros left review comments

@ffromani ffromani ffromani left review comments

@kpouget kpouget Awaiting requested review from kpouget

Assignees

@jmencak jmencak

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@MarSik @ffromani @jmencak @jlojosnegros @openshift-merge-robot