Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e:cpuloadbalance: deflake the test #730

Closed
wants to merge 5 commits into from
Closed

e2e:cpuloadbalance: deflake the test #730

wants to merge 5 commits into from

Commits on Jul 25, 2023

  1. e2e:cpuloadbalance: remove nested loop 

    return map from the `getCPUswithLoadBalanceDisabled` function
and then remove the nested loop from the check.

This is done only to make the test more clear and
not contain an actual fix.

Signed-off-by: Talor Itzhak <titzhak@redhat.com>
    @Tal-or
    Tal-or committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    206819b View commit details
    Browse the repository at this point in the history

  2. e2e:cpuloadbalance: fix cameCase format 

    Signed-off-by: Talor Itzhak <titzhak@redhat.com>
    @Tal-or
    Tal-or committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    9ead212 View commit details
    Browse the repository at this point in the history

  3. e2e:cpuloadbalance: verify sched domain before the test begins 

    The test pod is the only GU pod that requests for
cpu-load-balancing disable.

This means that all the cpus on the system should be
with cpu-load-balancing enable before test starts.

We should verify that before the test begin and bail out
early if it doesn't

Signed-off-by: Talor Itzhak <titzhak@redhat.com>
    @Tal-or
    Tal-or committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    8a8d06c View commit details
    Browse the repository at this point in the history

  4. e2e:cpuloadbalance: remove AfterEach 

    The pod get deleted during the test and there's only single `It` in
the node spec anyway, so the `AfterEach` is not needed

Signed-off-by: Talor Itzhak <titzhak@redhat.com>
    @Tal-or
    Tal-or committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    638a32d View commit details
    Browse the repository at this point in the history

  5. e2e:cpuloadbalance: simplified check after pod deletion 

    After the pod gets deleted, all cpus should be back into sched domain,
so the check should be simpler.

Signed-off-by: Talor Itzhak <titzhak@redhat.com>
    @Tal-or
    Tal-or committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    01ebf8d View commit details
    Browse the repository at this point in the history