OCPBUGS-14241: nto: pao avoid timeout when there are too many CSV

[jlojosnegros]

Adding pagination to CSVs list operation while deleting PAO OLM operator elements.

From versions >= 4.11 PAO has been integrated into NTO
For that reason PAO OLM operator elements (ClusterServiceVersion, Subscriptions .. ) should be deleted

As part of this operation CSVs are listed. This operation can take too long in some clusters due to the number of elements to be listed, and so the operation will hit a timeout and the pod will crash. This could end on a Crashbackloopsituation.

Adding pagination to the list operation should avoid this situation.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[jlojosnegros]

/cc @yanirq
/test all

[yanirq]

fix PR description: PAO is included in NTO since 4.11 (including)

[jlojosnegros]

/test e2e-gcp-pao-updating-profile

[jlojosnegros]

fix PR description: PAO is included in NTO since 4.11 (including)

thanks, done.

[openshift-ci-robot]

@jlojosnegros: This pull request references Jira Issue OCPBUGS-14241, which is invalid:

• expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Adding pagination to CSVs list operation while deleting PAO OLM operator elements.

From versions >= 4.11 PAO has been integrated into NTO
For that reason PAO OLM operator elements (ClusterServiceVersion, Subscriptions .. ) should be deleted

As part of this operation CSVs are listed. This operation can take too long in some clusters due to the number of elements to be listed, and so the operation will hit a timeout and the pod will crash. This could end on a Crashbackloopsituation.

Adding pagination to the list operation should avoid this situation.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jlojosnegros]

/jira refresh

[openshift-ci-robot]

@jlojosnegros: This pull request references Jira Issue OCPBUGS-14241, which is invalid:

• expected the bug to target only the "4.14.0" version, but multiple target versions were set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jlojosnegros]

/jira refresh

[openshift-ci-robot]

@jlojosnegros: This pull request references Jira Issue OCPBUGS-14241, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (liqcui@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jlojosnegros]

/retest

[jlojosnegros]

/retest

[MarSik]

The logic looks sound to me. However this needs manual validation, because our CI will not test the proper scenario on the main branch.

/lgtm
/approved

[jlojosnegros]

@yanirq PTAL
Thanks

[yanirq]

/payload-job periodic-ci-openshift-release-master-ci-4.15-upgrade-from-stable-4.14-e2e-gcp-ovn-upgrade

[openshift-ci]

@yanirq: trigger 1 job(s) for the /payload-(job|aggregate) command

• periodic-ci-openshift-release-master-ci-4.15-upgrade-from-stable-4.14-e2e-gcp-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/891fb440-5c66-11ee-83dd-0839f5003567-0

[yanirq]

/lgtm

[openshift-ci-robot]

@jlojosnegros: This pull request references Jira Issue OCPBUGS-14241, which is invalid:

• expected the bug to target the "4.15.0" version, but it targets "4.14.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Adding pagination to CSVs list operation while deleting PAO OLM operator elements.

From versions >= 4.11 PAO has been integrated into NTO
For that reason PAO OLM operator elements (ClusterServiceVersion, Subscriptions .. ) should be deleted

As part of this operation CSVs are listed. This operation can take too long in some clusters due to the number of elements to be listed, and so the operation will hit a timeout and the pod will crash. This could end on a Crashbackloopsituation.

Adding pagination to the list operation should avoid this situation.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jlojosnegros]

/jira refresh

[openshift-ci-robot]

@jlojosnegros: This pull request references Jira Issue OCPBUGS-14241, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.15.0) matches configured target version for branch (4.15.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (liqcui@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jlojosnegros]

/hold cancel
do not know why it still has the hold label

[jlojosnegros]

code rebased over latest master to overcome conflicts

[openshift-ci]

@jlojosnegros: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[ffromani]

/cherry-pick release-4.14

[openshift-cherrypick-robot]

@ffromani: once the present PR merges, I will cherry-pick it on top of release-4.14 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@jlojosnegros: you cannot LGTM your own PR.

In response to this:

/lgtm

Label dropped due to rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[MarSik]

/lgtm

[openshift-ci-robot]

@jlojosnegros: Jira Issue OCPBUGS-14241: All pull requests linked via external trackers have merged:

• openshift/cluster-node-tuning-operator#731

Jira Issue OCPBUGS-14241 has been moved to the MODIFIED state.

In response to this:

Adding pagination to CSVs list operation while deleting PAO OLM operator elements.

From versions >= 4.11 PAO has been integrated into NTO
For that reason PAO OLM operator elements (ClusterServiceVersion, Subscriptions .. ) should be deleted

As part of this operation CSVs are listed. This operation can take too long in some clusters due to the number of elements to be listed, and so the operation will hit a timeout and the pod will crash. This could end on a Crashbackloopsituation.

Adding pagination to the list operation should avoid this situation.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-cherrypick-robot]

@ffromani: #731 failed to apply on top of branch "release-4.14":

Applying: nto: avoid timeout when there are too many CSV
Using index info to reconstruct a base tree...
M	cmd/cluster-node-tuning-operator/main.go
Falling back to patching base and 3-way merge...
Auto-merging cmd/cluster-node-tuning-operator/main.go
CONFLICT (content): Merge conflict in cmd/cluster-node-tuning-operator/main.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 nto: avoid timeout when there are too many CSV
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.