Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-17258: CVE-2023-3978: golang.org/x/net/html #747

Conversation

jmencak
Copy link
Contributor

@jmencak jmencak commented Aug 3, 2023

This just simple vendoring/bump for golang.org/x to address CVE-2023-3978.

Resolves: OCPBUGS-17258

This just simple vendoring/bump for golang.org/x to address
CVE-2023-3978.

Resolves: OCPBUGS-17258
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Aug 3, 2023
@openshift-ci-robot
Copy link
Contributor

@jmencak: This pull request references Jira Issue OCPBUGS-17258, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (liqcui@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This just simple vendoring/bump for golang.org/x to address CVE-2023-3978.

Resolves: OCPBUGS-17258

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jmencak
Copy link
Contributor Author

jmencak commented Aug 3, 2023

@liqcui would you be able to review in David's absence?

@jmencak
Copy link
Contributor Author

jmencak commented Aug 3, 2023

Infra issues, insufficient capacity
/retest

@jmencak
Copy link
Contributor Author

jmencak commented Aug 3, 2023

/approve
/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmencak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2023
@jmencak
Copy link
Contributor Author

jmencak commented Aug 3, 2023

/retest

1 similar comment
@jmencak
Copy link
Contributor Author

jmencak commented Aug 4, 2023

/retest

@liqcui
Copy link

liqcui commented Aug 4, 2023

/lgtm
Since only update CVE related vendor packages, did a pre-merge testing of some basic NTO function, all looks good

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 4, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 0e3f9fc and 2 for PR HEAD 8b7bcf4 in total

@jmencak
Copy link
Contributor Author

jmencak commented Aug 4, 2023

ci/prow/e2e-hypershift tests keep failing. Looking at the test history, they have a very high failure rate.
/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 4, 2023

@jmencak: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 4e33d34 into openshift:master Aug 4, 2023
13 checks passed
@openshift-ci-robot
Copy link
Contributor

@jmencak: Jira Issue OCPBUGS-17258: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-17258 has been moved to the MODIFIED state.

In response to this:

This just simple vendoring/bump for golang.org/x to address CVE-2023-3978.

Resolves: OCPBUGS-17258

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jmencak jmencak deleted the 4.14-OCPBUGS-17258-CVE-2023-3978 branch August 4, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants