OCPBUGS-14026: cgroup: Match the name of the cgroup to what is expected by kubelet

[swatisehgal]

Ensure consistent naming of system cgroup in order to ensure that it matches cgroup name expected by Kubelet.

[swatisehgal]

/cc @haircommander @browsell

[browsell]

/lgtm

[yanirq]

@swatisehgal you might need to align the render command tests (see failing job for ci/prow/e2e-no-cluster)

[yanirq]

/retitle OCPBUGS-14026: cgroup: Match the name of the cgroup to what is expected by kubelet

[openshift-ci-robot]

@swatisehgal: This pull request references Jira Issue OCPBUGS-14026, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (mniranja@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Ensure consistent naming of system cgroup in order to ensure that it matches cgroup name expected by Kubelet.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[browsell]

/approve

[swatisehgal]

/retest

[Tal-or]

Is it possible to add an e2e for verifying the fix?

[openshift-ci]

@swatisehgal: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[browsell]

/lgtm

[swatisehgal]

/hold
The fix needs to be verified.

[swatisehgal]

Is it possible to add an e2e for verifying the fix?

Sure, I am currently thinking about how to to verify this fix. As per @MarSik there is potentially a race condition between kubelet and cpuset-configure so verifying the fix is going to be a bit tricky but let's see if we can find a way.

[yanirq]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: browsell, swatisehgal, yanirq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [yanirq]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[swatisehgal]

/unhold

As @browsell has verified the fix. We will defer adding the e2e test in a follow-up PR.

[openshift-ci-robot]

@swatisehgal: Jira Issue OCPBUGS-14026: All pull requests linked via external trackers have merged:

• openshift/cluster-node-tuning-operator#758

Jira Issue OCPBUGS-14026 has been moved to the MODIFIED state.

In response to this:

Ensure consistent naming of system cgroup in order to ensure that it matches cgroup name expected by Kubelet.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[swatisehgal]

/cherry-pick release-4.13

[openshift-cherrypick-robot]

@swatisehgal: #758 failed to apply on top of branch "release-4.13":

Applying: cgroup: Match the name of the cgroup to what is expected by kubelet
Using index info to reconstruct a base tree...
M	assets/performanceprofile/scripts/cpuset-configure.sh
Falling back to patching base and 3-way merge...
Auto-merging assets/performanceprofile/scripts/cpuset-configure.sh
Applying: cgroup: test: update content source for netdev physical rps rules
Using index info to reconstruct a base tree...
M	test/e2e/performanceprofile/testdata/render-expected-output/manual_machineconfig.yaml
Falling back to patching base and 3-way merge...
Auto-merging test/e2e/performanceprofile/testdata/render-expected-output/manual_machineconfig.yaml
CONFLICT (content): Merge conflict in test/e2e/performanceprofile/testdata/render-expected-output/manual_machineconfig.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 cgroup: test: update content source for netdev physical rps rules
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.