Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-17943: Add rtentsk plugin to pp tuned profile #767

Merged
merged 1 commit into from Aug 31, 2023
Merged

OCPBUGS-17943: Add rtentsk plugin to pp tuned profile #767

merged 1 commit into from Aug 31, 2023

Conversation

browsell
Copy link
Contributor

Signed-off-by: Brent Rowsell browsell@redhat.com

Add the rtentsk plugin to the openshift-node-performance tuned profile.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 21, 2023
@openshift-ci-robot
Copy link
Contributor

@browsell: This pull request references Jira Issue OCPBUGS-17943, which is invalid:

  • expected the bug to target the "4.14.0" version, but it targets "4.14" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Signed-off-by: Brent Rowsell browsell@redhat.com

Add the rtentsk plugin to the openshift-node-performance tuned profile.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Aug 21, 2023
@browsell
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Aug 21, 2023
@openshift-ci-robot
Copy link
Contributor

@browsell: This pull request references Jira Issue OCPBUGS-17943, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gsr-shanks

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Aug 21, 2023
@openshift-ci openshift-ci bot requested a review from gsr-shanks August 21, 2023 19:33
@openshift-merge-robot openshift-merge-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 22, 2023
@Tal-or
Copy link
Contributor

Tal-or commented Aug 22, 2023

@browsell Please run make render-sync and add the generated files to the PR

@yanirq
Copy link
Contributor

yanirq commented Aug 22, 2023 •
edited

based on redhat-performance/tuned#289

To be considered for a cherry picked.

@yanirq
Copy link
Contributor

yanirq commented Aug 22, 2023

@browsell please squash all the commits into one

@Tal-or
Copy link
Contributor

Tal-or commented Aug 22, 2023

/test e2e-hypershift

@yanirq
Copy link
Contributor

yanirq commented Aug 29, 2023

/retest

@yanirq
Copy link
Contributor

yanirq commented Aug 29, 2023

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 29, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: browsell, yanirq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2023
@Tal-or
Copy link
Contributor

Tal-or commented Aug 29, 2023

@browsell Could you please squash the commits in the PR?

@yanirq
Copy link
Contributor

yanirq commented Aug 29, 2023

@browsell Could you please squash the commits in the PR?

right
/hold until squashed.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 29, 2023
OCPBUGS-17943: Add rtentsk plugin to pp tuned profile
994890f 
Signed-off-by: Brent Rowsell <browsell@redhat.com>

Add the rtentsk to the openshift-node-performance tuned profile.
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 30, 2023
@browsell
Copy link
Contributor Author

/test e2e-gcp-pao

@yanirq
Copy link
Contributor

yanirq commented Aug 31, 2023

/lgtm

@yanirq
Copy link
Contributor

yanirq commented Aug 31, 2023

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. lgtm Indicates that a PR is ready to be merged. labels Aug 31, 2023
@Tal-or
Copy link
Contributor

Tal-or commented Aug 31, 2023

/hold cancel
commits were squashed

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 31, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 0c4ce0a and 2 for PR HEAD 994890f in total

@browsell
Copy link
Contributor Author

/test e2e-gcp-pao-workloadhints

@browsell
Copy link
Contributor Author

/test e2e-hypershift

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 31, 2023

@browsell: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 6784795 into openshift:master Aug 31, 2023
13 checks passed
@openshift-ci-robot
Copy link
Contributor

@browsell: Jira Issue OCPBUGS-17943: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-17943 has been moved to the MODIFIED state.

In response to this:

Signed-off-by: Brent Rowsell browsell@redhat.com

Add the rtentsk plugin to the openshift-node-performance tuned profile.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Tal-or
Copy link
Contributor

Tal-or commented Sep 3, 2023

/cherry pick release-4.13

@shajmakh
Copy link
Contributor

/cherry pick release-4.13

/cc @Tal-or
/cherry-pick release-4.13

@openshift-cherrypick-robot
Copy link

@shajmakh: new pull request created: #796

In response to this:

/cherry pick release-4.13

/cc @Tal-or
/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlojosnegros jlojosnegros Awaiting requested review from jlojosnegros

@Tal-or Tal-or Awaiting requested review from Tal-or

@gsr-shanks gsr-shanks Awaiting requested review from gsr-shanks

Assignees

@yanirq yanirq

Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@browsell @openshift-ci-robot @Tal-or @yanirq @shajmakh @openshift-cherrypick-robot @openshift-merge-robot