Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CNF-10294: main: remove deprecated multi ns function #770

Merged
merged 2 commits into from Nov 8, 2023
Merged

CNF-10294: main: remove deprecated multi ns function #770

merged 2 commits into from Nov 8, 2023

Conversation

Tal-or
Copy link
Contributor

@Tal-or Tal-or commented Aug 22, 2023

The latest operator SDK version allow specifying
multiple namespaces directly as part of the cache options.

Functionality would remain the same.

@Tal-or
Copy link
Contributor Author

Tal-or commented Aug 22, 2023

@jmencak I closed #762 because I thought there's a bug in the CI bot.

This doesn't seem like the problem, so this has the exact same content as #762 let's just wait until master will open again.

@jmencak
Copy link
Contributor

jmencak commented Aug 22, 2023

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmencak, Tal-or

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 22, 2023
@Tal-or
Copy link
Contributor Author

Tal-or commented Aug 22, 2023

/retest

@ffromani
Copy link
Contributor

/test e2e-upgrade

seems infra issue

@Tal-or
Copy link
Contributor Author

Tal-or commented Aug 24, 2023

/retest

1 similar comment
@Tal-or
Copy link
Contributor Author

Tal-or commented Sep 5, 2023

/retest

@Tal-or
Copy link
Contributor Author

Tal-or commented Sep 13, 2023

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Sep 13, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 0707c79 and 2 for PR HEAD 14974dd in total

@Tal-or
Copy link
Contributor Author

Tal-or commented Sep 13, 2023

/retest

3 similar comments
@Tal-or
Copy link
Contributor Author

Tal-or commented Sep 14, 2023

/retest

@Tal-or
Copy link
Contributor Author

Tal-or commented Sep 14, 2023

/retest

@Tal-or
Copy link
Contributor Author

Tal-or commented Sep 27, 2023

/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD d698198 and 2 for PR HEAD 14974dd in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 0cd2735 and 1 for PR HEAD 14974dd in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 890d5ee and 0 for PR HEAD 14974dd in total

@openshift-ci-robot
Copy link
Contributor

/hold

Revision 14974dd was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 30, 2023
@Tal-or
main: remove deprecated multi ns function
5102ca4 
The latest operator SDK version allow specifying
multiple namespaces directly as part of the cache options.

Functionality would remain the same.

Signed-off-by: Talor Itzhak <titzhak@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2023
@jmencak
Copy link
Contributor

jmencak commented Oct 31, 2023

Dropping

//nolint:staticcheck

should fix the linter issue.

@Tal-or
Copy link
Contributor Author

Tal-or commented Nov 2, 2023

/retest

@Tal-or
main: remove lint skip
32b20a8 
The issue was with the depracated function, now that we fix it, we can remove the annotation.

Signed-off-by: Talor Itzhak <titzhak@redhat.com>
@Tal-or
Copy link
Contributor Author

Tal-or commented Nov 5, 2023

/retest

@jmencak
Copy link
Contributor

jmencak commented Nov 5, 2023

Thank you for the PR.
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 5, 2023
@Tal-or
Copy link
Contributor Author

Tal-or commented Nov 8, 2023

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 8, 2023
@ffromani
Copy link
Contributor

ffromani commented Nov 8, 2023

/remove-label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot removed the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Nov 8, 2023
@ffromani
Copy link
Contributor

ffromani commented Nov 8, 2023

/label jira/valid-reference

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 8, 2023

@ffromani: The label(s) /label jira/valid-reference cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, downstream-change-needed, rebase/manual, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label jira/valid-reference

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Tal-or Tal-or changed the title main: remove deprecated multi ns function CNF-10294: main: remove deprecated multi ns function Nov 8, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 8, 2023 •
edited by openshift-ci bot

@Tal-or: This pull request references CNF-10294 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

The latest operator SDK version allow specifying
multiple namespaces directly as part of the cache options.

Functionality would remain the same.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 8, 2023
@Tal-or
Copy link
Contributor Author

Tal-or commented Nov 8, 2023

/jira refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 8, 2023 •
edited by openshift-ci bot

@Tal-or: This pull request references CNF-10294 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Tal-or
Copy link
Contributor Author

Tal-or commented Nov 8, 2023

/jira refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 8, 2023 •
edited by openshift-ci bot

@Tal-or: This pull request references CNF-10294 which is a valid jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 8, 2023

@Tal-or: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit f2e0fb3 into openshift:master Nov 8, 2023
14 checks passed
@ffromani ffromani deleted the deprecated_multi_ns branch November 8, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlojosnegros jlojosnegros Awaiting requested review from jlojosnegros

@jmencak jmencak Awaiting requested review from jmencak

Assignees

@jmencak jmencak

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Tal-or @jmencak @ffromani @openshift-ci-robot