OCPBUGS-18650: Memory manager E2E test fixes #784
Conversation
Minor left over fixes of Memory manager E2E Test cases Signed-off-by: Niranjan M.R <mrniranjan@redhat.com>
|
/test e2e-gcp-pao-updating-profile |
mrniranjan
changed the title
openshift-ci-robot
added
jira/severity-low
|
@mrniranjan: This pull request references Jira Issue OCPBUGS-18650, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (mniranja@redhat.com), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
jira/valid-bug
| profile.Spec.WorkloadHints = &performancev2.WorkloadHints{ | ||
| RealTime: pointer.Bool(true), | ||
| } | ||
| profile.Spec.WorkloadHints = &performancev2.WorkloadHints{ |
There was a problem hiding this comment.
so we are always forcing the hints to this value. Is that what we really need to do? Is it a problem if we overwrite other hints?
There was a problem hiding this comment.
Right because if we set RealTime to true, then having a profile with Realtime performance hint being disabled would cause issues, So we wanted to make it default to have Realtime workload hint to be true, other workload hints are not an issue.
There was a problem hiding this comment.
Provided we restore the profile correctly if needed, and we don't pollute any global state (e.g. is the profile instance being changed unique to the testcase or shared among testcases?), fine for me.
There was a problem hiding this comment.
Yes, we take backup and restore after the tests.
| profile.Spec.WorkloadHints = &performancev2.WorkloadHints{ | ||
| RealTime: pointer.Bool(true), | ||
| } | ||
| profile.Spec.WorkloadHints = &performancev2.WorkloadHints{ |
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold cancel questions answered |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ffromani, mrniranjan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest-required |
|
/test e2e-gcp-pao |
|
@mrniranjan: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@mrniranjan: Jira Issue OCPBUGS-18650: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-18650 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Minor left over fixes of Memory manager E2E Test cases