Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-18662: e2e:rps: improve logging #787

Merged

Commits on Sep 6, 2023

  1. e2e:rps: log the expected rps mask

    print the expected rps mask for physical and virtual network devices.
    This change would help with debugging the test in case of failure.
    
    Signed-off-by: Talor Itzhak <titzhak@redhat.com>
    Tal-or committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    93c69f1 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2023

  1. e2e:rps: print mask instead of cpuset

    Printing the rps masks in case of failure is more readable then printing the cpuset.
    this is because an empty mask i.e 0000 is interpeted as an empty cpuset i.e "" (empty quotes)
    
    Signed-off-by: Talor Itzhak <titzhak@redhat.com>
    Tal-or committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    370cb8b View commit details
    Browse the repository at this point in the history
  2. e2e:rps: print device path with wrong mask

    In case the test failed, we asserts only the desired and actual mask,
    but we are not specifing the device on which the RPS mask was bad.
    
    This patch adds the full device path as part of the error message.
    
    Signed-off-by: Talor Itzhak <titzhak@redhat.com>
    Tal-or committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    1e37c03 View commit details
    Browse the repository at this point in the history