Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-18783: e2e: perfprof: enhance the scheduling domain tests #791

Merged
merged 5 commits into from Sep 27, 2023
Merged

OCPBUGS-18783: e2e: perfprof: enhance the scheduling domain tests #791

merged 5 commits into from Sep 27, 2023

Conversation

ffromani
Copy link
Contributor

@ffromani ffromani commented Sep 13, 2023 •
edited

Add simple parser for /proc/schedstat, to have a good foundation for load balancing disabling tests.
Use it into the scheduling domains tests to make the test more precise and (hopefully) the failure conditions clearer.
Finally, builds on the aforementioned to tight up the tests.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2023
@ffromani ffromani force-pushed the schedstat branch 2 times, most recently from d7fdc6c to 8d92f8a Compare September 13, 2023 16:53
Tal-or
Tal-or reviewed Sep 14, 2023
View reviewed changes
Copy link
Contributor

@Tal-or Tal-or left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, left couple of notes.

pkg/performanceprofile/utils/schedstat/schedstat.go Outdated Show resolved Hide resolved
test/e2e/performanceprofile/functests/utils/pods/pods.go Outdated Show resolved Hide resolved
test/e2e/performanceprofile/functests/1_performance/cpu_management.go Outdated Show resolved Hide resolved
test/e2e/performanceprofile/functests/1_performance/cpu_management.go Outdated Show resolved Hide resolved
@ffromani ffromani changed the title utils: schedstat: add simple parser e2e: perfprof: enhance the scheduling domain tests Sep 14, 2023
@ffromani ffromani changed the title e2e: perfprof: enhance the scheduling domain tests OCPBUGS-18783: e2e: perfprof: enhance the scheduling domain tests Sep 14, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Sep 14, 2023
@openshift-ci-robot
Copy link
Contributor

@ffromani: This pull request references Jira Issue OCPBUGS-18783, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (mniranja@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Add simple parser for /proc/schedstat, to have a good foundation for load balancing disabling tests.
use it into the scheduling domains tests to make the test more precise and (hopefully) the failure conditions clearer

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ffromani ffromani force-pushed the schedstat branch 2 times, most recently from 4b8039c to 3f7354d Compare September 14, 2023 09:32
@ffromani
Copy link
Contributor Author

/retest

@openshift-ci-robot
Copy link
Contributor

@ffromani: This pull request references Jira Issue OCPBUGS-18783, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (mniranja@redhat.com), skipping review request.

In response to this:

Add simple parser for /proc/schedstat, to have a good foundation for load balancing disabling tests.
Use it into the scheduling domains tests to make the test more precise and (hopefully) the failure conditions clearer.
Finally, builds on the aforementioned to tight up the tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mrniranjan mrniranjan mentioned this pull request Sep 14, 2023
Closed
@ffromani
Copy link
Contributor Author

/retest

@ffromani
Copy link
Contributor Author

/retest

this change can't break unrelated lanes. One last try before we start to deep dive nto actual failures

@ffromani
Copy link
Contributor Author

/cherry-pick release-4.14

@openshift-cherrypick-robot
Copy link

@ffromani: once the present PR merges, I will cherry-pick it on top of release-4.14 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ffromani
Copy link
Contributor Author

/retest

infra issue

@ffromani
Copy link
Contributor Author

/retest

@ffromani
Copy link
Contributor Author

/retest-required

@ffromani
Copy link
Contributor Author

/retest

@ffromani
Copy link
Contributor Author

/retest

apiserver failure

@ffromani
e2e: perfprof: workaround issues.k8s.io/107074
0235a9e 
It's likely we are htting this issue.
We did't notice so far likely because we were'nt
checking the global node state after gu pod removal.

Signed-off-by: Francesco Romani <fromani@redhat.com>
@ffromani
e2e: perfprof: extract function
82ea1b5 
extract function for better readability - it didn't
use any nontrivial variable closure anyway.
No intended change in behavior.

Signed-off-by: Francesco Romani <fromani@redhat.com>
@ffromani
Copy link
Contributor Author

/retest

3 similar comments
@ffromani
Copy link
Contributor Author

/retest

@ffromani
Copy link
Contributor Author

/retest

@ffromani
Copy link
Contributor Author

/retest

@ffromani
Copy link
Contributor Author

/cc @mrniranjan

@yanirq
Copy link
Contributor

yanirq commented Sep 21, 2023

looks good to me overall. do we need all the separate commits here or can we squash them all into one ?

@ffromani
Copy link
Contributor Author

looks good to me overall. do we need all the separate commits here or can we squash them all into one ?

I don't see a reason to squash them, but if we prefer this way I don't mind too much

@yanirq
Copy link
Contributor

yanirq commented Sep 21, 2023

/lgtm
/hold
remove hold once all required peers have a review

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 21, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 21, 2023
@ffromani
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 22, 2023
@ffromani
Copy link
Contributor Author

/retest

received unexpected HTTP status: 504 Gateway Time-out

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 78c64b2 and 2 for PR HEAD 82ea1b5 in total

@ffromani
Copy link
Contributor Author

/retest

@ffromani
Copy link
Contributor Author

/retest

more timeouts, more 504s

@ffromani
Copy link
Contributor Author

/retest

sigh

@yanirq
Copy link
Contributor

yanirq commented Sep 26, 2023

/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 4ca8e91 and 1 for PR HEAD 82ea1b5 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 27, 2023

@ffromani: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit d698198 into openshift:master Sep 27, 2023
13 checks passed
@openshift-ci-robot
Copy link
Contributor

@ffromani: Jira Issue OCPBUGS-18783: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-18783 has been moved to the MODIFIED state.

In response to this:

Add simple parser for /proc/schedstat, to have a good foundation for load balancing disabling tests.
Use it into the scheduling domains tests to make the test more precise and (hopefully) the failure conditions clearer.
Finally, builds on the aforementioned to tight up the tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 27, 2023
Merged
@openshift-cherrypick-robot
Copy link

@ffromani: new pull request created: #813

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ffromani ffromani deleted the schedstat branch September 27, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanirq yanirq yanirq left review comments

@Tal-or Tal-or Tal-or left review comments

@dagrayvid dagrayvid Awaiting requested review from dagrayvid

@mrniranjan mrniranjan Awaiting requested review from mrniranjan

Assignees

@yanirq yanirq

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ffromani @openshift-ci-robot @openshift-cherrypick-robot @yanirq @Tal-or @openshift-merge-robot