Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

render: change directory path #824

Merged
merged 1 commit into from Oct 13, 2023
Merged

Conversation

Tal-or
Copy link
Contributor

@Tal-or Tal-or commented Oct 12, 2023

When #778 got merged, the directory layout has changed and broke the render-sync make target. This patch should fix it.

When openshift#778 got merged
The directory layout has changed and broke the `render-sync`  make target.
This patch should fix it.

Signed-off-by: Talor Itzhak <titzhak@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 12, 2023

@Tal-or: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ffromani
Copy link
Contributor

/approve
/lgtm

please backport if/as needed

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani, Tal-or

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2023
@openshift-ci openshift-ci bot merged commit e5181f4 into openshift:master Oct 13, 2023
14 checks passed
@Tal-or
Copy link
Contributor Author

Tal-or commented Oct 15, 2023

/cherrypick release-4.14

@openshift-cherrypick-robot

@Tal-or: new pull request created: #826

In response to this:

/cherrypick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants