Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-JIRA: e2e: images: bump default test image to 4.14 #856

Merged
merged 1 commit into from Dec 8, 2023
Merged

NO-JIRA: e2e: images: bump default test image to 4.14 #856

merged 1 commit into from Dec 8, 2023

Conversation

ffromani
Copy link
Contributor

no reason to keep referencing the ancient 4.9

@ffromani
e2e: images: bump default test image to 4.14
90cec56 
no reason to keep referencing the ancient 4.9

Signed-off-by: Francesco Romani <fromani@redhat.com>
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 23, 2023
jmencak
jmencak approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@jmencak jmencak left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image quay.io/openshift-kni/cnf-tests:4.14 exists, so
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 23, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani, jmencak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ffromani
Copy link
Contributor Author

ffromani commented Dec 5, 2023

/hold
/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Dec 5, 2023
@ffromani ffromani changed the title e2e: images: bump default test image to 4.14 NO-JIRA: e2e: images: bump default test image to 4.14 Dec 5, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 5, 2023
@openshift-ci-robot
Copy link
Contributor

@ffromani: This pull request explicitly references no jira issue.

In response to this:

no reason to keep referencing the ancient 4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ffromani
Copy link
Contributor Author

ffromani commented Dec 5, 2023

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@ffromani: This pull request explicitly references no jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yanirq
Copy link
Contributor

yanirq commented Dec 5, 2023

/lgtm

@ffromani
Copy link
Contributor Author

ffromani commented Dec 5, 2023

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 5, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD e9fa899 and 2 for PR HEAD 90cec56 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 901f395 and 1 for PR HEAD 90cec56 in total

@jmencak
Copy link
Contributor

jmencak commented Dec 7, 2023

/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 570bbfd and 0 for PR HEAD 90cec56 in total

@openshift-ci-robot
Copy link
Contributor

/hold

Revision 90cec56 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 7, 2023
@jmencak
Copy link
Contributor

jmencak commented Dec 8, 2023

/retest

@jmencak
Copy link
Contributor

jmencak commented Dec 8, 2023

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 8, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 5f7ac24 and 2 for PR HEAD 90cec56 in total

@jmencak
Copy link
Contributor

jmencak commented Dec 8, 2023

/retest

2 similar comments
@jmencak
Copy link
Contributor

jmencak commented Dec 8, 2023

/retest

@jmencak
Copy link
Contributor

jmencak commented Dec 8, 2023

/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 8, 2023

@ffromani: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 5843abb into openshift:master Dec 8, 2023
14 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-node-tuning-operator-container-v4.16.0-202312082332.p0.g5843abb.assembly.stream for distgit cluster-node-tuning-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmencak jmencak jmencak approved these changes

@dagrayvid dagrayvid Awaiting requested review from dagrayvid

Assignees

@yanirq yanirq

@jmencak jmencak

Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ffromani @openshift-ci-robot @yanirq @jmencak @openshift-bot