TRT-1376: Revert #854 " OCPBUGS-18640: Fix Racing Machine Configs and add Day 0 Support" #863
Conversation
…ort (openshift#854)" This reverts commit b70869c.
openshift-ci-robot
added
the
jira/valid-reference
|
@dgoodwin: This pull request references TRT-1376 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dgoodwin The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/payload-job periodic-ci-openshift-release-master-nightly-4.15-e2e-metal-ipi-sdn-bm |
|
@dgoodwin: trigger 1 job(s) for the /payload-(job|aggregate) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/74075000-904a-11ee-8559-6b22b1acf0e2-0 |
|
/payload-job periodic-ci-openshift-release-master-nightly-4.15-e2e-metal-ipi-sdn-bm The one above doesn't appear to be running |
|
@stbenjam: trigger 1 job(s) for the /payload-(job|aggregate) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/3066b3f0-904e-11ee-9db0-f37bd6b6000f-0 |
|
Still failing here but working on other prs... /payload-job periodic-ci-openshift-release-master-nightly-4.15-e2e-metal-ipi-sdn-bm |
|
@dgoodwin: trigger 1 job(s) for the /payload-(job|aggregate) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f9495460-9050-11ee-9204-10744d83d930-0 |
What I don't understand is how will we know this revert actually fixes the issue while in the meantime openshift/cluster-storage-operator#426 merged? Also, why this test job wasn't run in openshift/cluster-storage-operator#426 ? |
|
FWIW the reverted PR didn't create roles; actually didn't create new objects at all, rather updating existing objects and waiting for them before continuing its own reconciliation. |
|
@dgoodwin: This pull request references TRT-1376 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
|
@dgoodwin: This pull request references TRT-1376 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Apologies I got the wrong incident link, TRT-1377 was the one this test was for, but we found it in another test revert, this change was not involved. /close |
|
@dgoodwin: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Reverts #854 ; tracked by TRT-1377
Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.
THIS IS A TEST REVERT. We do not yet know what has caused metal sdn jobs to wedge on bootstrap, but some of our tooling pointed to this commit as a possible regression so we're just doing some testing to see if it resolved the problem.
To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:
CC: @ffromani