NO-JIRA: Report duplicate profiles as ERRORs #864
Conversation
|
/cc @MarSik |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jmencak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
pkg/manifests/manifests.go
Outdated
| @@ -133,7 +133,7 @@ func tunedRenderedProfiles(tuned *tunedv1.Tuned, m map[string]tunedv1.TunedProfi | |||
| if *v.Data == *existingProfile.Data { | |||
| klog.Infof("duplicate profiles names %s but they have the same contents", *v.Name) | |||
| } else { | |||
| klog.Warningf("WARNING: duplicate profiles named %s with different contents", *v.Name) | |||
| klog.Errorf("ERROR: duplicate profiles named %s with different contents!", *v.Name) | |||
There was a problem hiding this comment.
Is here a way to print the Tuned object name the profile comes from too? And maybe the profile that was selected (+ its parent Tuned) at the end of the loop?
There was a problem hiding this comment.
Is here a way to print the Tuned object name the profile comes from too?
Yes. I added it to the PR.
And maybe the profile that was selected (+ its parent Tuned) at the end of the loop?
Not sure what exactly do you mean, but I'm sensing it would require larger code changes and hopefully the above is sufficient.
In the past, duplicate profiles were being report as WARNINGs only. Increase seriousness of this fact, so that it helps the users to fix their configuration issues.
jmencak
force-pushed
the
4.15-duplicate-profile-error
branch
from
8a50b4d
to
a5af660
Compare
|
I'm fine with the idea here. Do we report or want to report this condition as |
Thank you for the review. 'Degraded' is reported in profiles.tuned.openshift.io, but not for this particular situation. We might in the future, but as you say, not in this PR (added to my TODO list). @MarSik , please see if the changes are sufficient, so that we can get this in 4.15.0. Thank you! |
|
/lgtm waiting for second opinion from @MarSik |
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold cancel I would also like to see a Tuned.Status.Conditions improvement, but this is a good step forward. |
|
/lgtm |
openshift-ci
bot
removed
the
do-not-merge/hold
jmencak
changed the title
|
@jmencak: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
@jmencak: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build cluster-node-tuning-operator-container-v4.15.0-202312041611.p0.ge9fa899.assembly.stream for distgit cluster-node-tuning-operator. |
In the past, duplicate profiles were being report as WARNINGs only. Increase seriousness of this fact, so that it helps the users to fix their configuration issues.