Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNF-10676: makefile: add target to trigger mixedcpus e2e test #883

Merged
merged 1 commit into from Dec 14, 2023

Conversation

Tal-or
Copy link
Contributor

@Tal-or Tal-or commented Dec 14, 2023

This make target should be called in the new TechPreviewNoUpgrade job and run some sanity tests: openshift/release#46767

After the job get settle, we should add all the other e2e tests that were planned.

Signed-off-by: Talor Itzhak <titzhak@redhat.com>
@ffromani
Copy link
Contributor

/approve

adding this makefile target seems uncontroversial and safe

Copy link
Contributor

openshift-ci bot commented Dec 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani, Tal-or

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2023
@ffromani
Copy link
Contributor

/retest

infra issue (failed to pull some images)

@Tal-or
Copy link
Contributor Author

Tal-or commented Dec 14, 2023

/retest

@ffromani
Copy link
Contributor

/lgtm

seems fine, and a new Makefile target can hardly break existing flows.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 14, 2023
@Tal-or
Copy link
Contributor Author

Tal-or commented Dec 14, 2023

/retest

@Tal-or Tal-or changed the title makefile: add target to trigger mixedcpus e2e test CNF-10676: makefile: add target to trigger mixedcpus e2e test Dec 14, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 14, 2023

@Tal-or: This pull request references CNF-10676 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

This make target should be called in the new TechPreviewNoUpgrade job and run some sanity tests: openshift/release#46767

After the job get settle, we should add all the other e2e tests that were planned.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 14, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 29d73bd and 2 for PR HEAD 42dbfd8 in total

@Tal-or
Copy link
Contributor Author

Tal-or commented Dec 14, 2023

/retest

Copy link
Contributor

openshift-ci bot commented Dec 14, 2023

@Tal-or: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test e2e-aws-operator
  • /test e2e-aws-ovn
  • /test e2e-gcp-pao
  • /test e2e-gcp-pao-updating-profile
  • /test e2e-gcp-pao-workloadhints
  • /test e2e-hypershift
  • /test e2e-no-cluster
  • /test e2e-upgrade
  • /test images
  • /test unit
  • /test verify
  • /test vet

The following commands are available to trigger optional jobs:

  • /test lint

Use /test all to run all jobs.

In response to this:

/retest new make target should not affect the tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Tal-or
Copy link
Contributor Author

Tal-or commented Dec 14, 2023

/retest
New make target should not affect the tests

@Tal-or
Copy link
Contributor Author

Tal-or commented Dec 14, 2023

/retest

Copy link
Contributor

openshift-ci bot commented Dec 14, 2023

@Tal-or: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit fd20f57 into openshift:master Dec 14, 2023
14 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-node-tuning-operator-container-v4.16.0-202312150050.p0.gfd20f57.assembly.stream for distgit cluster-node-tuning-operator.
All builds following this will include this PR.

@Tal-or
Copy link
Contributor Author

Tal-or commented Feb 8, 2024

/cherry-pick release-4.15

@openshift-cherrypick-robot

@Tal-or: new pull request created: #941

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants