[release-4.15] OCPBUGS-25596: Make MC names deterministic #888
Conversation
OpenShift Nodes can be a part of only one custom MachineConfigPool. However, MCP configuration allows this not to be the case. This is caught by the machine-config-controller and reported as an error (<node> belongs to <N> custom roles, cannot proceed with this Node). In order to target an MCP with a configuration, NTO uses machineConfigLabels. However, one or more MCPs can select a particular single MC. This is due to the MCP's machineConfigSelector. This is another challenge scenario. In the above two scenarios, it was possible for NTO to generate a randomly-named MC based on the membership of one of the matching MCPs. Then, a pruning function would mistakenly remove the other MCs, seemingly unused. This could result in a flip between the rendered MCs and cause a Node reboot. This PR makes the process of establishing the names of the MC for the purposes of MachineConfigPool based matching deterministic. Other changes/fixes: - Synced with MCO's latest getPoolsForNode() changes. - Logging in syncMachineConfigHyperShift(). Resolves: OCPBUGS-24792
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-24792 has been cloned as Jira Issue OCPBUGS-25596. Will retitle bug to link to clone. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
changed the title
|
/approve |
openshift-ci-robot
added
jira/severity-moderate
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-25596, which is valid. The bug has been moved to the POST state. 6 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (liqcui@redhat.com), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jmencak, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest |
|
/label backport-risk-assessed |
openshift-ci
bot
added
the
backport-risk-assessed
|
/label cherry-pick-approved |
openshift-ci
bot
added
the
cherry-pick-approved
|
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit 590ba65
into
openshift:release-4.15
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-25596: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-25596 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build cluster-node-tuning-operator-container-v4.15.0-202312191811.p0.g590ba65.assembly.stream for distgit cluster-node-tuning-operator. |
This is an automated cherry-pick of #875
/assign jmencak