CNF-9173: e2e: mixedcpus test #892

Tal-or · 2023-12-19T10:51:46Z

This is a first PR (more to come) that tests the mixed-cpus e2e.
It contains the following tests:

Basic test to verify that pod which asks for shared cpus, has the shared cpus under
its cgroup cpuset.
Check that cpu-quota.crio.io: disable annotation works along with mixedcpus.
Check that OPENSHIFT_ISOLATED_CPUS and OPENSHIFT_SHARED_CPUS env variables are under the container and configured properly.
Verify that updates to shared CPUs under the profile are reflect under the containers correctly.

openshift-ci-robot · 2023-12-19T10:51:49Z

@Tal-or: This pull request references CNF-9173 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

This is a first PR (more to come) that tests the mixed-cpus e2e.
It contains the following tests:

Basic test to verify that pod which asks for shared cpus, has the shared cpus under
its cgroup cpuset.

Check that cpu-quota.crio.io: disable annotation works along with mixedcpus.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Tal-or · 2023-12-19T10:53:02Z

depends on cri-o/cri-o#7608

openshift-ci-robot · 2023-12-21T17:03:03Z

@Tal-or: This pull request references CNF-9173 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

This is a first PR (more to come) that tests the mixed-cpus e2e.
It contains the following tests:

Basic test to verify that pod which asks for shared cpus, has the shared cpus under
its cgroup cpuset.

Check that cpu-quota.crio.io: disable annotation works along with mixedcpus.

Check that OPENSHIFT_ISOLATED_CPUS and OPENSHIFT_SHARED_CPUS env variables are under the container and configured properly.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2024-01-02T12:48:17Z

@Tal-or: This pull request references CNF-9173 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

This is a first PR (more to come) that tests the mixed-cpus e2e.
It contains the following tests:

Basic test to verify that pod which asks for shared cpus, has the shared cpus under
its cgroup cpuset.

Check that cpu-quota.crio.io: disable annotation works along with mixedcpus.

Check that OPENSHIFT_ISOLATED_CPUS and OPENSHIFT_SHARED_CPUS env variables are under the container and configured properly.

Check if shared CPUs survive Kubelet restart.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

test/e2e/performanceprofile/functests/utils/cgroup/v1/v1.go

Tal-or · 2024-01-09T09:34:38Z

/hold
depends on #906

Tal-or · 2024-01-09T09:36:02Z

/test e2e-aws-ovn-techpreview

test/e2e/performanceprofile/functests/11_mixedcpus/mixedcpus.go

openshift-ci-robot · 2024-01-10T09:54:37Z

@Tal-or: This pull request references CNF-9173 which is a valid jira issue.

In response to this:

This is a first PR (more to come) that tests the mixed-cpus e2e.
It contains the following tests:

Basic test to verify that pod which asks for shared cpus, has the shared cpus under
its cgroup cpuset.

Check that cpu-quota.crio.io: disable annotation works along with mixedcpus.

Check that OPENSHIFT_ISOLATED_CPUS and OPENSHIFT_SHARED_CPUS env variables are under the container and configured properly.

Verify that updates to shared CPUs under the profile are reflect under the containers correctly.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Tal-or · 2024-01-11T19:39:05Z

/retest

openshift-ci · 2024-02-07T13:06:43Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani, Tal-or

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [ffromani]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

mrniranjan · 2024-02-07T15:23:07Z

@Tal-or @shajmakh if these tests are important, we need to add test case id's and add it to our test case management systems. Its not something very urgent can be addressed in another PR

This test changes the shared cpuset under the profile, wait for mcp to catchup, and checks if the container has been updated to reflect the new shared cpuset. Signed-off-by: Talor Itzhak <titzhak@redhat.com>

Use `mustParse` to make sure we assert in case of invalid cpuset string Signed-off-by: Talor Itzhak <titzhak@redhat.com>

The controller file names on cgroupv1 are different than the one on cgroupv2. This is a pure copy-paste mistake. Signed-off-by: Talor Itzhak <titzhak@redhat.com>

Tal-or · 2024-02-07T15:59:02Z

@Tal-or @shajmakh if these tests are important, we need to add test case id's and add it to our test case management systems. Its not something very urgent can be addressed in another PR

Yes we can add id's later on, you're welcome to provide list of valid ids and we shall add them.

ffromani · 2024-02-07T16:43:22Z

LGTM

* Check the len returned from split * Use `GinkgoHelper()` Signed-off-by: Talor Itzhak <titzhak@redhat.com>

Tal-or · 2024-02-08T15:16:59Z

/cherry-pick release-4.15

openshift-cherrypick-robot · 2024-02-08T15:17:01Z

@Tal-or: once the present PR merges, I will cherry-pick it on top of release-4.15 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

shajmakh · 2024-02-08T15:22:42Z

@Tal-or @shajmakh if these tests are important, we need to add test case id's and add it to our test case management systems. Its not something very urgent can be addressed in another PR

Yes we can add id's later on, you're welcome to provide list of valid ids and we shall add them.

indeed they are, and they're part of the TP so when imported to Polarion the ids will get generated and I'll consider to add them accordingly.

/lgtm
/hold
for other reviewers
@Tal-or feel free to unhold as you see fit.

Tal-or · 2024-02-08T15:44:35Z

Thanks @shajmakh I'm doing some local tests on 4.15 and will remove the hold if they are passing

Tal-or · 2024-02-12T09:38:08Z

/hold cancel
Tests are passing on 4.15 cgroupv1

openshift-ci-robot · 2024-02-12T10:35:20Z

/retest-required

Remaining retests: 0 against base HEAD f68b3a2 and 2 for PR HEAD 9bd0341 in total

openshift-ci · 2024-02-12T12:04:25Z

@Tal-or: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-cherrypick-robot · 2024-02-12T12:08:53Z

@Tal-or: #892 failed to apply on top of branch "release-4.15":

Applying: e2e: allowed annotation to ns
Applying: e2e: mixedcpus: add e2e tests
Using index info to reconstruct a base tree...
M	test/e2e/performanceprofile/functests/11_mixedcpus/mixedcpus.go
Falling back to patching base and 3-way merge...
Auto-merging test/e2e/performanceprofile/functests/11_mixedcpus/mixedcpus.go
CONFLICT (content): Merge conflict in test/e2e/performanceprofile/functests/11_mixedcpus/mixedcpus.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 e2e: mixedcpus: add e2e tests
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2024-02-12T14:27:51Z

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-node-tuning-operator-container-v4.16.0-202402121340.p0.g836b327.assembly.stream.el9 for distgit cluster-node-tuning-operator.
All builds following this will include this PR.

* e2e: allowed annotation to ns The the allowed mixedcpus annotation to the testing namespace. Without the annotation the api admission pliugin will reject the request for the workload creation. Signed-off-by: Talor Itzhak <titzhak@redhat.com> * e2e: mixedcpus: add e2e tests 1. Basic test to verify that pod which asks for shared cpus, has the shared cpus under its cgroup cpuset. 2. Check that `cpu-quota.crio.io: disable` annotation works along with mixedcpus. Signed-off-by: Talor Itzhak <titzhak@redhat.com> * e2e: check env variable exsitance Signed-off-by: Talor Itzhak <titzhak@redhat.com> * e2e: cancel SMT alignment On some environments we have very few resources. On order to be able to run tests on those type of environment, we must narrow down the resources required by the test pod, but yet keep their guaranteed QoS class. This means that one is the minimal possible, but the pod will failed with SMT alignment error, hence in such cases we want to cancel the SMT alignment. Signed-off-by: Talor Itzhak <titzhak@redhat.com> * e2e: test updates to shared cpus under profile This test changes the shared cpuset under the profile, wait for mcp to catchup, and checks if the container has been updated to reflect the new shared cpuset. Signed-off-by: Talor Itzhak <titzhak@redhat.com> * e2e: use `mustParse` Use `mustParse` to make sure we assert in case of invalid cpuset string Signed-off-by: Talor Itzhak <titzhak@redhat.com> * e2e: fix controller file naming The controller file names on cgroupv1 are different than the one on cgroupv2. This is a pure copy-paste mistake. Signed-off-by: Talor Itzhak <titzhak@redhat.com> * e2e: addressed reviewers comments * Check the len returned from split * Use `GinkgoHelper()` Signed-off-by: Talor Itzhak <titzhak@redhat.com> --------- Signed-off-by: Talor Itzhak <titzhak@redhat.com>

* CNF-9173: e2e: mixedcpus test (#892) * e2e: allowed annotation to ns The the allowed mixedcpus annotation to the testing namespace. Without the annotation the api admission pliugin will reject the request for the workload creation. Signed-off-by: Talor Itzhak <titzhak@redhat.com> * e2e: mixedcpus: add e2e tests 1. Basic test to verify that pod which asks for shared cpus, has the shared cpus under its cgroup cpuset. 2. Check that `cpu-quota.crio.io: disable` annotation works along with mixedcpus. Signed-off-by: Talor Itzhak <titzhak@redhat.com> * e2e: check env variable exsitance Signed-off-by: Talor Itzhak <titzhak@redhat.com> * e2e: cancel SMT alignment On some environments we have very few resources. On order to be able to run tests on those type of environment, we must narrow down the resources required by the test pod, but yet keep their guaranteed QoS class. This means that one is the minimal possible, but the pod will failed with SMT alignment error, hence in such cases we want to cancel the SMT alignment. Signed-off-by: Talor Itzhak <titzhak@redhat.com> * e2e: test updates to shared cpus under profile This test changes the shared cpuset under the profile, wait for mcp to catchup, and checks if the container has been updated to reflect the new shared cpuset. Signed-off-by: Talor Itzhak <titzhak@redhat.com> * e2e: use `mustParse` Use `mustParse` to make sure we assert in case of invalid cpuset string Signed-off-by: Talor Itzhak <titzhak@redhat.com> * e2e: fix controller file naming The controller file names on cgroupv1 are different than the one on cgroupv2. This is a pure copy-paste mistake. Signed-off-by: Talor Itzhak <titzhak@redhat.com> * e2e: addressed reviewers comments * Check the len returned from split * Use `GinkgoHelper()` Signed-off-by: Talor Itzhak <titzhak@redhat.com> --------- Signed-off-by: Talor Itzhak <titzhak@redhat.com> * e2e: check if shared CPUs survive Kubelet restart Signed-off-by: Talor Itzhak <titzhak@redhat.com> * e2e: remove ctx arg Leftovers from the cherry-pick which was done from 4.16. On 4.16 we already updated most of our functions to accept context as the first argument. On 4.15 we don't, hence we shall remove it. Signed-off-by: Talor Itzhak <titzhak@redhat.com> * e2e: `UpdateWithRetry` only update spec The function contains a subtle bug on which the update is done only for fileds under the `Spec` This means that changes to annotations and labels field outside the `Spec` won't take affect. Signed-off-by: Talor Itzhak <titzhak@redhat.com> --------- Signed-off-by: Talor Itzhak <titzhak@redhat.com>

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 19, 2023

openshift-ci bot requested review from ffromani and kpouget December 19, 2023 10:52

Tal-or force-pushed the mixed_cpu_plugin_e2e branch 2 times, most recently from 9194a1b to a57ec98 Compare December 20, 2023 14:32

Tal-or force-pushed the mixed_cpu_plugin_e2e branch from 12ffc0d to 1510113 Compare January 2, 2024 14:03

mrniranjan reviewed Jan 4, 2024

View reviewed changes

test/e2e/performanceprofile/functests/utils/cgroup/v1/v1.go Outdated Show resolved Hide resolved

Tal-or mentioned this pull request Jan 4, 2024

CNF-9173: e2e: cgroups: introduce cgroup package #906

Merged

mrniranjan reviewed Jan 8, 2024

View reviewed changes

test/e2e/performanceprofile/functests/utils/cgroup/v1/v1.go Outdated Show resolved Hide resolved

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 9, 2024

Tal-or force-pushed the mixed_cpu_plugin_e2e branch 2 times, most recently from 8356653 to 257c1d7 Compare January 10, 2024 09:32

ffromani reviewed Jan 10, 2024

View reviewed changes

test/e2e/performanceprofile/functests/11_mixedcpus/mixedcpus.go Outdated Show resolved Hide resolved

test/e2e/performanceprofile/functests/11_mixedcpus/mixedcpus.go Outdated Show resolved Hide resolved

Tal-or force-pushed the mixed_cpu_plugin_e2e branch from 257c1d7 to 628dcd1 Compare January 10, 2024 09:45

Tal-or mentioned this pull request Jan 10, 2024

CNF-9173: e2e: mixedcpus: kubelet restart test #912

Merged

Tal-or force-pushed the mixed_cpu_plugin_e2e branch from 628dcd1 to 10a9a43 Compare January 10, 2024 09:53

Tal-or force-pushed the mixed_cpu_plugin_e2e branch 4 times, most recently from 2dad186 to db4015d Compare January 11, 2024 13:23

Tal-or force-pushed the mixed_cpu_plugin_e2e branch 2 times, most recently from 2527030 to aa4c3b0 Compare January 16, 2024 16:13

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2024

Tal-or added 3 commits February 7, 2024 17:42

e2e: test updates to shared cpus under profile

b4b16e9

This test changes the shared cpuset under the profile, wait for mcp to catchup, and checks if the container has been updated to reflect the new shared cpuset. Signed-off-by: Talor Itzhak <titzhak@redhat.com>

e2e: use mustParse

03bc703

Use `mustParse` to make sure we assert in case of invalid cpuset string Signed-off-by: Talor Itzhak <titzhak@redhat.com>

e2e: fix controller file naming

38bc10c

The controller file names on cgroupv1 are different than the one on cgroupv2. This is a pure copy-paste mistake. Signed-off-by: Talor Itzhak <titzhak@redhat.com>

Tal-or force-pushed the mixed_cpu_plugin_e2e branch from 69cdb14 to 9362e00 Compare February 7, 2024 15:57

Tal-or force-pushed the mixed_cpu_plugin_e2e branch from 9362e00 to 4d77c46 Compare February 8, 2024 11:30

e2e: addressed reviewers comments

9bd0341

* Check the len returned from split * Use `GinkgoHelper()` Signed-off-by: Talor Itzhak <titzhak@redhat.com>

Tal-or force-pushed the mixed_cpu_plugin_e2e branch from 4d77c46 to 9bd0341 Compare February 8, 2024 11:47

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 8, 2024

openshift-ci bot assigned shajmakh Feb 8, 2024

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 8, 2024

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 12, 2024

openshift-merge-bot bot merged commit 836b327 into openshift:master Feb 12, 2024
15 checks passed

Tal-or mentioned this pull request Feb 13, 2024

[release-4.15][manual] OCPBUGS-29376: Mixed CPUs e2e tests #952

Merged

Tal-or deleted the mixed_cpu_plugin_e2e branch February 19, 2024 09:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CNF-9173: e2e: mixedcpus test #892

CNF-9173: e2e: mixedcpus test #892

Tal-or commented Dec 19, 2023 •

edited

openshift-ci-robot commented Dec 19, 2023 •

edited by openshift-ci bot

Tal-or commented Dec 19, 2023

openshift-ci-robot commented Dec 21, 2023 •

edited by openshift-ci bot

openshift-ci-robot commented Jan 2, 2024 •

edited by openshift-ci bot

Tal-or commented Jan 9, 2024

Tal-or commented Jan 9, 2024

openshift-ci-robot commented Jan 10, 2024 •

edited by openshift-ci bot

Tal-or commented Jan 11, 2024

openshift-ci bot commented Feb 7, 2024

mrniranjan commented Feb 7, 2024

Tal-or commented Feb 7, 2024 •

edited

ffromani commented Feb 7, 2024

Tal-or commented Feb 8, 2024

openshift-cherrypick-robot commented Feb 8, 2024

shajmakh commented Feb 8, 2024 •

edited

Tal-or commented Feb 8, 2024

Tal-or commented Feb 12, 2024

openshift-ci-robot commented Feb 12, 2024

openshift-ci bot commented Feb 12, 2024

openshift-cherrypick-robot commented Feb 12, 2024

openshift-bot commented Feb 12, 2024

CNF-9173: e2e: mixedcpus test #892

CNF-9173: e2e: mixedcpus test #892

Conversation

Tal-or commented Dec 19, 2023 • edited

openshift-ci-robot commented Dec 19, 2023 • edited by openshift-ci bot

Tal-or commented Dec 19, 2023

openshift-ci-robot commented Dec 21, 2023 • edited by openshift-ci bot

openshift-ci-robot commented Jan 2, 2024 • edited by openshift-ci bot

Tal-or commented Jan 9, 2024

Tal-or commented Jan 9, 2024

openshift-ci-robot commented Jan 10, 2024 • edited by openshift-ci bot

Tal-or commented Jan 11, 2024

openshift-ci bot commented Feb 7, 2024

mrniranjan commented Feb 7, 2024

Tal-or commented Feb 7, 2024 • edited

ffromani commented Feb 7, 2024

Tal-or commented Feb 8, 2024

openshift-cherrypick-robot commented Feb 8, 2024

shajmakh commented Feb 8, 2024 • edited

Tal-or commented Feb 8, 2024

Tal-or commented Feb 12, 2024

openshift-ci-robot commented Feb 12, 2024

openshift-ci bot commented Feb 12, 2024

openshift-cherrypick-robot commented Feb 12, 2024

openshift-bot commented Feb 12, 2024

Tal-or commented Dec 19, 2023 •

edited

openshift-ci-robot commented Dec 19, 2023 •

edited by openshift-ci bot

openshift-ci-robot commented Dec 21, 2023 •

edited by openshift-ci bot

openshift-ci-robot commented Jan 2, 2024 •

edited by openshift-ci bot

openshift-ci-robot commented Jan 10, 2024 •

edited by openshift-ci bot

Tal-or commented Feb 7, 2024 •

edited

shajmakh commented Feb 8, 2024 •

edited