OCPBUGS-24581: rps: fail gracefully when mask application failed #895
Conversation
openshift-ci-robot
added
jira/valid-reference
|
@Tal-or: This pull request references Jira Issue OCPBUGS-24581, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cc @MarSik |
In case the device gets removed completely, We want to hide the error, becuase we should not care of applying rps mask for devices which are gone anyway. Signed-off-by: Talor Itzhak <titzhak@redhat.com>
Tal-or
force-pushed
the
fix_rps_for_sriov_devs
branch
from
0bea136
to
d97495b
Compare
|
@Tal-or: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Tal-or
changed the title
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Tal-or, yanirq The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@Tal-or: This pull request references Jira Issue OCPBUGS-24581, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (mniranja@redhat.com), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@Tal-or: Jira Issue OCPBUGS-24581: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-24581 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@Tal-or: cannot checkout In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.15 |
|
@Tal-or: new pull request created: #897 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build cluster-node-tuning-operator-container-v4.16.0-202312251331.p0.ge63d2c9.assembly.stream for distgit cluster-node-tuning-operator. |
In case the the physical network device gets removed completely,
We want to hide the error,
because we should not care of applying rps mask for devices which are gone anyway.
It's important to emphasis that the rps mask is set correctly and this PR intended to fail gracefully in case
devices that were removed.