NO-JIRA: HyperShift code linter PR837 followup

[jmencak]

#456 introduced support for MachineConfig-like functionality for HyperShift via NTO. This PR unnecessarily creates a runtime.Scheme on every invocation of getMachineConfigFromConfigMap() and serializeMachineConfig() function as pointed out in #837 (comment). Make the scheme an attribute of the controller and initialize it only once at controller instantiation.

/cc

[openshift-ci]

@jmencak: GitHub didn't allow me to request PR reviews from the following users: jmencak.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

#456 introduced support for MachineConfig-like functionality for HyperShift via NTO. This PR unnecessarily creates a runtime.Scheme on every invocation of getMachineConfigFromConfigMap() and serializeMachineConfig() function as pointed out in #837 (comment). Make the scheme an attribute of the controller and initialize it only once at controller instantiation.

/cc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmencak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jmencak]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jmencak]

/cc @dagrayvid
/cc @ffromani
Francesco, hope this is the direction you wanted the issues in #837 (comment) resolved.

I have not tested this manually in HyperShift, as it can be quite time consuming. I believe this should be covered by the ci/prow/e2e-hypershift. @dagrayvid , please keep me honest here.

[ffromani]

thanks @jmencak this change indeed addresses my suggestion.
non-binding LGTM till we are sure the code is covered by tests (and only because we're not sure and checking)

[dagrayvid]

@jmencak Yes that is right. I also checked the logs of the e2e-hypershift test to confirm:

        --- PASS: TestNodePool/Main/TestNTOMachineConfigGetsRolledOut (1315.21s)
            --- PASS: TestNodePool/Main/TestNTOMachineConfigGetsRolledOut/EnsureNoCrashingPods (0.02s)
            --- PASS: TestNodePool/Main/TestNTOMachineConfigGetsRolledOut/EnsureAllContainersHavePullPolicyIfNotPresent (0.01s)
            --- PASS: TestNodePool/Main/TestNTOMachineConfigGetsRolledOut/EnsureHCPContainersHaveResourceRequests (0.01s)
            --- PASS: TestNodePool/Main/TestNTOMachineConfigGetsRolledOut/EnsureNoPodsWithTooHighPriority (0.02s)

/lgtm

[dagrayvid]

/retest-required

[jmencak]

/retest

[jmencak]

/retest

[openshift-ci-robot]

@jmencak: This pull request explicitly references no jira issue.

In response to this:

#456 introduced support for MachineConfig-like functionality for HyperShift via NTO. This PR unnecessarily creates a runtime.Scheme on every invocation of getMachineConfigFromConfigMap() and serializeMachineConfig() function as pointed out in #837 (comment). Make the scheme an attribute of the controller and initialize it only once at controller instantiation.

/cc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 7820510 and 2 for PR HEAD 0de6589 in total

[jmencak]

ci/prow/e2e-gcp-pao-updating-profile issues likely caused by https://issues.redhat.com/browse/OCPBUGS-26589

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD cff2950 and 1 for PR HEAD 0de6589 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD dfc37fc and 0 for PR HEAD 0de6589 in total

[jmencak]

/retest

[openshift-ci-robot]

/hold

Revision 0de6589 was retested 3 times: holding

[jmencak]

/hold cancel
/retest

[openshift-ci]

@jmencak: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-node-tuning-operator-container-v4.16.0-202401162251.p0.gf2f453f.assembly.stream for distgit cluster-node-tuning-operator.
All builds following this will include this PR.