Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "NO-JIRA: skip crun configuration test" #918

Merged
merged 1 commit into from Jan 30, 2024

Conversation

Tal-or
Copy link
Contributor

@Tal-or Tal-or commented Jan 16, 2024

Reverts #917
a crun version that contains containers/crun#1384 fix is in, let's see if the test is passing now

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 16, 2024
@openshift-ci-robot
Copy link
Contributor

@Tal-or: This pull request explicitly references no jira issue.

In response to this:

Reverts #917

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Tal-or
Copy link
Contributor Author

Tal-or commented Jan 16, 2024

/retest

@Tal-or
Copy link
Contributor Author

Tal-or commented Jan 16, 2024

/retest
crun updates didn't catch up yet

@Tal-or
Copy link
Contributor Author

Tal-or commented Jan 17, 2024

/retest

2 similar comments
@Tal-or
Copy link
Contributor Author

Tal-or commented Jan 25, 2024

/retest

@Tal-or
Copy link
Contributor Author

Tal-or commented Jan 29, 2024

/retest

@ffromani
Copy link
Contributor

/approve

we indeed want to revert ASAP

Copy link
Contributor

openshift-ci bot commented Jan 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani, Tal-or

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2024
@yanirq
Copy link
Contributor

yanirq commented Jan 30, 2024

/lgtm

@yanirq
Copy link
Contributor

yanirq commented Jan 30, 2024

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Jan 30, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2024
Copy link
Contributor

openshift-ci bot commented Jan 30, 2024

@Tal-or: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 9f9465e into openshift:master Jan 30, 2024
15 checks passed
@Tal-or Tal-or deleted the revert-917-dnm_skip branch January 31, 2024 09:55
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-node-tuning-operator-container-v4.16.0-202401311150.p0.g9f9465e.assembly.stream for distgit cluster-node-tuning-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants